bug#13002: closed (directory variables in VALAFLAGS are expanded after cd)

[GNU bug Tracking System]

Your message dated Sat, 7 Nov 2020 19:45:20 -0700
with message-id <202011080245.0A82jKGQ016587@freefriends.org>
and subject line Re: bug#13002: Updated, fixed patch
has caused the debbugs.gnu.org bug report #13002,
regarding directory variables in VALAFLAGS are expanded after cd
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
13002: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13002
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> directory variables in VALAFLAGS are expanded after cd
>
>
>
>
> Date: 
>
> Mon, 26 Nov 2012 20:03:38 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
>
>
>
>
> Hi,
>
> I see quite a few Vala projects setting VALAFLAGS as follows:
>
> libfolks_eds_la_VALAFLAGS = \
>         --vapidir=. \
>         --vapidir=$(top_srcdir)/folks \
>         ...
>
> This is referred by the generated rule in Makefile.in as:
>
> $(AM_V_VALAC)$(am__cd) $(srcdir) && $(VALAC) $(libfolks_eds_la_VALAFLAGS) 
> $(VALAFLAGS) -C $(libfolks_eds_la_SOURCES)
>
> Here, if $(srcdir) != $(builddir) and $(top_srcdir) is a relative path
> from $(builddir), the --vapidir option will point to a wrong location.
>
> Though this could be worked around by using $(abs_top_srcdir) instead of
> $(top_srcdir), it looks to me a bit unintuitive.  It would be nice that
> automake handles this case nicely.
>
> Regards,
> -- 
> Daiki Ueno
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#13002: Updated, fixed patch
>
>
>
>
> Date: 
>
> Sat, 7 Nov 2020 19:45:20 -0700
>
>
>
>
>     I have taken Daniel Espinosa's patch and improved it so that it
>     fixes all the test failures.
>
> Reuben, thank you very much for dealing with everything, and thanks to
> Daniel for the original work.
>
> make check && make distcheck are working for me now.
> I have pushed the changes (with fingers crossed)
> and am closing this bug. -k
>
>
> --- End Message ---