bug#37832: closed (internal-border face ignored in Emacs 26.3 for macOS)

[GNU bug Tracking System]

Your message dated Fri, 25 Sep 2020 17:23:05 +0100
with message-id <20200925162305.GG28875@breton.holly.idiocy.org>
and subject line Re: bug#41071: make-frame with internal-border face not working
has caused the debbugs.gnu.org bug report #41071,
regarding internal-border face ignored in Emacs 26.3 for macOS
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41071: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41071
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> internal-border face ignored in Emacs 26.3 for macOS
>
>
>
>
> Date: 
>
> Sun, 20 Oct 2019 15:25:54 +0200
>
>
>
>
> The `internal-border` face is ignored and the `default` face
> background is used instead. I'm experiencing this with Emacs 26.3
> installed with `brew cask install emacs`.
>
> Reproduce with the following `.emacs`:
>
> (custom-set-variables
>  '(default-frame-alist '((internal-border-width . 100))))
>
> (custom-set-faces
>  '(default ((t (:background "black" :foreground "white"))))
>  '(internal-border ((t (:background "red")))))
>
> Works fine on Linux version 26.1.
>
>
> Andrea
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#41071: make-frame with internal-border face not working
>
>
>
>
> Date: 
>
> Fri, 25 Sep 2020 17:23:05 +0100
>
>
>
>
> On Wed, Sep 23, 2020 at 02:03:27PM +0100, Alan Third wrote:
> > On Mon, May 04, 2020 at 03:30:09PM +0800, 王凯 wrote:
> > > 
> > > (defface test
> > >   '((t (:inherit default :background "green")))
> > >   "Face used by the ivy-posframe."
> > >   :group 'ivy-posframe)
> > > 
> > > (set-face-background
> > > 'internal-border
> > > (face-attribute 'test :background)
> > > (make-frame `((internal-border-width . 100)
> > >                (parent-frame . ,(window-frame)))))
> > > 
> > > (set-face-background
> > > 'internal-border
> > > (face-attribute 'test :background)
> > > (make-frame `((internal-border-width . 100))))
> > > 
> > > Eval code above in emacs, internal-border-width works but the
> > > :background not.
> > 
> > Patch against master attached. It appears to work correctly here, but
> > I'm slightly concerned it may not work so well on older versions of
> > macOS, but we'll probably just have to wait and see if anyone
> > complains.
>
> I've pushed the change to master and therefore am closing this bug
> report.
> -- 
> Alan Third
>
>
> --- End Message ---