bug#43135: closed (28.0.50; image.c compiler warning)

[GNU bug Tracking System]

Your message dated Thu, 3 Sep 2020 21:57:18 +0200 (CEST)
with message-id <20200903195715.GB93185@breton.holly.idiocy.org>
and subject line Re: bug#43135: 28.0.50; image.c compiler warning
has caused the debbugs.gnu.org bug report #43135,
regarding 28.0.50; image.c compiler warning
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
43135: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43135
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 28.0.50; image.c compiler warning
>
>
>
>
> Date: 
>
> Mon, 31 Aug 2020 14:52:44 +0100
>
>
>
>
> For the last week or so I'm seeing this warning when compiling master,
> always using the simple command 'make' in the git repo:
>
>   CC       image.o
> image.c: In function 'svg_load_image':
> image.c:9892:3: warning: implicit declaration of function 'free'
> [-Wimplicit-function-declaration]
>    free (wrapped_contents);
>    ^
> image.c:9892:3: warning: incompatible implicit declaration of built-in
> function 'free'
> image.c:9892:3: note: include '<stdlib.h>' or provide a declaration of
> 'free'
>
> This is a 32-bit build, and Slackware 14.2's gcc is 5.5.0. The
> executable runs just fine.
>
> The warning appears after commit
> 8f42b94fe43911c6b0c7e519ba439d61459dc744 by Alan Third:
> Set basic SVG attributes (bug#40845)
>
> Including <stdlib.h> at the top of image.c does silence the warning.
>
> If my toolchain is outdated please forgive and ignore the noise.
>
> Thanks,
>
> David.
>
> In GNU Emacs 28.0.50 (build 36, i686-pc-linux-gnu, GTK+ Version
> 3.18.9, cairo version 1.14.6)
>  of 2020-08-31 built on newfont
> Repository revision: 58d962379546762c7eead8fc69c4c136bed8256b
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
> System Description: Slackware 14.2
>
> Configured using:
>  'configure
>  
> PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig'
>
> Configured features:
> XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
> INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS
> GTK3 X11 XDBE XIM MODULES THREADS PDUMPER LCMS2
>
> Important settings:
>   value of $LC_COLLATE: C
>   value of $LANG: en_US.ISO8859-1
>   locale-coding-system: iso-latin-1-unix
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#43135: 28.0.50; image.c compiler warning
>
>
>
>
> Date: 
>
> Thu, 3 Sep 2020 21:57:18 +0200 (CEST)
>
>
>
>
> On Wed, Sep 02, 2020 at 07:34:39AM +0100, David Fussner via Bug reports for GNU 
> Emacs, the Swiss army knife of text editors wrote:
> > Hi Alan,
> > 
> > Yes, that works for me. Many thanks for the quick response, and please
> > close the bug.
>
> Thanks, I've pushed it to master now.
> -- 
> Alan Third
>
>
> --- End Message ---