The attached patch is a proposal that would replace the function `eieio-persistent-convert-list-to-object' with a generic method `eieio-persistent-make-instance'. It also removes all slot validation in the read process. Considerations: 1. `object-write' is already a method. That means the writing process can be overridden and customized, but the reading process can't, which removes most of the benefit of being able to override the write. This would allow "matching" methods for writing and reading. 2. This version checks *all* slot values, including all elements inside lists, cons-cells, etc. The safety consideration is mostly removing text properties (specifically the display property), and this version checks exhaustively. 3. I removed slot validation because it complicates the restoration process, and because all the validation will be done again, and done better, by `cl-typep' in the `initialize-instance' process. There's not much reason to have a "pre-check", as errors are raised in both cases. 4. This version goes slightly faster than the old one (admittedly, probably just because it omits type-checking). Persistence format isn't changed, so this should be backwards compatible. I suppose the removal of validation might not be welcome, but at least I hope the function->generic change is acceptable. In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2017-11-30 built on slip Repository revision: 3f3d98ee5851840228786390ee7dbf851d144eb8
0001-Replace-eieio-persistent-convert-list-to-object-with.patch
Description: Text Data
--- End Message ---