bug#42457: closed ([PATCH] gnu: knights: Fix build.)

[GNU bug Tracking System]

Your message dated Tue, 28 Jul 2020 21:13:17 +0300
with message-id <87ime7mrsy.fsf@gmail.com>
and subject line Re: [bug#42457] [PATCH] gnu: knights: Fix build.
has caused the debbugs.gnu.org bug report #42457,
regarding [PATCH] gnu: knights: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42457: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42457
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: knights: Fix build.
>
>
>
>
> Date: 
>
> Tue, 21 Jul 2020 00:11:05 -0600
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Icedove/68.10.0
>
>
>
>
> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"
> ---
> gnu/packages/games.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
> (build-system gnu-build-system)
> (arguments
> '(#:make-flags
> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> + "CXXFLAGS=-lpthread")
> #:phases
> (modify-phases %standard-phases
> ;; No configure script.
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#42457] [PATCH] gnu: knights: Fix build. Date: Tue, 28 Jul 2020 21:13:17 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi,

[…]

> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"

Rather:
* gnu/packages/games.scm (knights)[arguments]<#:make-flags>: Add
"CXXFLAGS=-lpthread".

> ---
>  gnu/packages/games.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
>      (build-system gnu-build-system)
>      (arguments
>       '(#:make-flags
> -       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +          "CXXFLAGS=-lpthread")

^
Please, use spaces instead of tabs. ;-)

>         #:phases
>         (modify-phases %standard-phases
>           ;; No configure script.

Pushed to master with mentioned changes.

Oleg.

signature.asc
Description: PGP signature

--- End Message ---