emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#42087: closed ([PATCH 6/6] gnu: Add python-pre-commit.)


From: GNU bug Tracking System
Subject: bug#42087: closed ([PATCH 6/6] gnu: Add python-pre-commit.)
Date: Sat, 25 Jul 2020 16:39:03 +0000

Your message dated Sat, 25 Jul 2020 18:38:31 +0200
with message-id <87k0yrsg6w.fsf@gnu.org>
and subject line Re: [bug#42082] [PATCH v2 6/6] gnu: Add python-pre-commit.
has caused the debbugs.gnu.org bug report #42082,
regarding [PATCH 6/6] gnu: Add python-pre-commit.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42082: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42082
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 6/6] gnu: Add python-pre-commit. Date: Sat, 27 Jun 2020 12:46:45 -0300
* gnu/packages/python-xyz.scm (python-pre-commit): New variable.
---
 gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9eac0ff74f..972eb64d8e 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16852,6 +16852,34 @@ Glob2 currently based on the glob code from Python 
3.3.1.")
 (define-public python2-glob2
   (package-with-python2 python-glob2))
 
+(define-public python-pre-commit
+  (package
+    (name "python-pre-commit")
+    (version "2.5.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pre_commit" version))
+       (sha256
+        (base32 "1ivl921kdk9wga2cix4j9ydvs3dryqaaayq496pzjmz2y3w3qins"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;tests require python-tox >= 3.13
+    (propagated-inputs
+     `(("python-cfgv" ,python-cfgv)
+       ("python-identify" ,python-identify)
+       ("python-nodeenv" ,python-nodeenv)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-toml" ,python-toml)
+       ("python-virtualenv" ,python-virtualenv)))
+    (home-page "https://pre-commit.com/";)
+    (synopsis "Framework for managing and maintaining multi-language 
pre-commit hooks")
+    (description
+     "Pre-commit is a multi-language package manager for pre-commit hooks.  You
+specify a list of hooks you want and pre-commit manages the installation and
+execution of any hook written in any language before every commit.")
+    (license license:expat)))
+
 (define-public python-gipc
   (package
     (name "python-gipc")
-- 
2.20.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#42082] [PATCH v2 6/6] gnu: Add python-pre-commit. Date: Sat, 25 Jul 2020 18:38:31 +0200
Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/version-control.scm (pre-commit): New variable.
> ---
> Enable tests. Update to 2.6.0.
>
> Language tests require interpreters/compilers and build systems as inputs
> and downloading packages online (e.g. 'go get'), hence disabled.

Makes sense.

[...]
  
> +         (replace 'check
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (add-installed-pythonpath inputs outputs)
> +             (invoke "pytest" "tests" "-k"
> +                     (string-append
> +                     ;; Disable conda tests.
> +                      "not test_conda_hook"
> +                      " and not test_conda_with_additional_dependencies_hook"
> +                      " and not test_local_conda_additional_dependencies"
> +                      ;; Disable cpan tests.
> +                      " and not test_local_perl_additional_dependencies"
> +                      " and not test_perl_hook"
> +                      ;; Disable Ruby tests.
> +                      " and not test_additional_ruby_dependencies_installed"
> +                      " and not test_install_rbenv"
> +                      " and not test_install_rbenv_with_version"
> +                      " and not test_run_a_ruby_hook"
> +                      " and not test_run_ruby_hook_with_disable_shared_gems"
> +                      " and not test_run_versioned_ruby_hook"
> +                      ;; Disable Cargo tests
> +                      " and not 
> test_additional_rust_cli_dependencies_installed"
> +                      " and not 
> test_additional_rust_lib_dependencies_installed"
> +                      " and not test_local_rust_additional_dependencies"
> +                      " and not test_rust_hook"
> +                      ;; Disable python2 test.
> +                      " and not test_switch_language_versions_doesnt_clobber"
> +                      ;; These tests try to open a network socket.
> +                      " and not 
> test_additional_golang_dependencies_installed"
> +                      " and not test_additional_node_dependencies_installed"
> +                      " and not test_golang_hook"
> +                      " and not 
> test_golang_hook_still_works_when_gobin_is_set"
> +                      " and not test_local_golang_additional_dependencies"
> +                      " and not test_main"
> +                      " and not test_node_hook_with_npm_userconfig_set"
> +                      " and not test_run_a_node_hook"
> +                      " and not test_run_versioned_node_hook"
> +                      ;; Tests failing with a permission error.
> +                      ;; They try to write to the filesystem.
> +                      " and not test_autoupdate_hook_disappearing_repo"
> +                      " and not test_hook_disppearing_repo_raises"
> +                      " and not test_img_conflict"
> +                      " and not test_img_something_unstaged"
> +                      " and not test_installed_from_venv"
> +                      " and not test_too_new_version"
> +                      " and not test_try_repo_uncommitted_changes"
> +                      " and not test_versions_ok"
> +                      ;; This test tries to activate a virtualenv
> +                      " and not test_healthy_venv_creator"
> +                      ;; Fatal error: Not a Git repository.
> +                      " and not test_all_cmds"
> +                      " and not test_try_repo"
> +                      ;; No module named 'pip._internal.cli.main'
> +                      " and not test_additional_dependencies_roll_forward"
> +                      ; Assertion errors
> +                      " and not test_install_existing_hooks_no_overwrite"
> +                      " and not test_uninstall_restores_legacy_hooks"))))

Wooooow, nice work!

I've applied this and the other patches in the series.  Thanks again!  :-)

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]