bug#42280: closed ([PATCH 1/2] gnu: Add bshapr.)

[GNU bug Tracking System]

Your message dated Tue, 21 Jul 2020 00:17:41 +0200
with message-id <87blk9hlve.fsf@gnu.org>
and subject line Re: [bug#42280] [PATCH 1/2] gnu: Add bshapr.
has caused the debbugs.gnu.org bug report #42280,
regarding [PATCH 1/2] gnu: Add bshapr.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42280: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42280
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH 1/2] gnu: Add bshapr. Date: Wed, 08 Jul 2020 22:36:56 +0100 User-agent: Evolution 3.34.2

Hi,

These patches add bshapr and bjumblr, 2 LV2 plugins. I used inheritance
from bsequencer since they are by the same author and use the same
build procedure/system.

Thanks,
Alex

0002-gnu-Add-bjumblr.patch
Description: Text Data

0001-gnu-Add-bshapr.patch
Description: Text Data

signature.asc
Description: This is a digitally signed message part

--- End Message ---

--- Begin Message --- Subject: Re: [bug#42280] [PATCH 1/2] gnu: Add bshapr. Date: Tue, 21 Jul 2020 00:17:41 +0200

Alexandros Theodotou <alex@zrythm.org> writes:

> Hi,
>
> These patches add bshapr and bjumblr, 2 LV2 plugins. I used inheritance
> from bsequencer since they are by the same author and use the same
> build procedure/system.

Inheritance is a double-edged sword: someone making changes to
bsequencer may not realize that it affects these two packages.  I've
ignored that for now, but would not mind a patch to 'un-inherit' them.

[...]

> * gnu/packages/music.scm (bjumblr): New variable.

[...]
  
> +(define-public bjumblr
> +  (package
> +    (inherit bsequencer)
> +    (name "bjumblr")
> +    (version "0.2")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/sjaehn/BJumblr.git";)

I removed the .git suffix from these patches, as well as the ninja2
patch earlier, ref commit b0e7b6992f3f845e83cfbca4d700b51dba50b4d5.

> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "14z8113zkwykbhm1a8h2xs972dgifvlfij92b08jckyc7cbz84ys"))))

Also, indentation is off for both patches (but fixed!).

[...]

> +    (description "B.Shapr is a beat/envelope shaper LV2 plugin")

Missing punctuation (also fixed).  :-)

Applied!

signature.asc
Description: PGP signature

--- End Message ---