bug#42293: closed ([PATCH] gnu: fish: Update to 3.1.2.)

[GNU bug Tracking System]

Your message dated Sun, 12 Jul 2020 21:58:32 +0300
with message-id <20200712185832.GG9396@E5400>
and subject line Re: [bug#42293] [PATCH] gnu: fish: Update to 3.1.2.
has caused the debbugs.gnu.org bug report #42293,
regarding [PATCH] gnu: fish: Update to 3.1.2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42293: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42293
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: fish: Update to 3.1.2.
>
>
>
>
> Date: 
>
> Thu,  9 Jul 2020 11:07:58 +0200
>
>
>
>
> * gnu/packages/shells.scm (fish): Update to 3.1.2.
> [arguments] Set HOME to a writable folder. Remove a failing test file.
> ---
>  gnu/packages/shells.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
> index b790a0cc18..3bdda7c786 100644
> --- a/gnu/packages/shells.scm
> +++ b/gnu/packages/shells.scm
> @@ -99,7 +99,7 @@ direct descendant of NetBSD's Almquist Shell 
> (@command{ash}).")
>  (define-public fish
>    (package
>      (name "fish")
> -    (version "3.1.0")
> +    (version "3.1.2")
>      (source
>       (origin
>         (method url-fetch)
> @@ -107,7 +107,7 @@ direct descendant of NetBSD's Almquist Shell 
> (@command{ash}).")
>                             "releases/download/" version "/"
>                             "fish-" version ".tar.gz"))
>         (sha256
> -        (base32 "0s2356mlx7fp9kgqgw91lm5ds2i9iq9hq071fbqmcp3875l1xnz5"))))
> +        (base32 "1vblmb3x2k2cb0db5jdyflppnlqsm7i6jjaidyhmvaaw7ch2gffm"))))
>      (build-system cmake-build-system)
>      (inputs
>       `(("fish-foreign-env" ,fish-foreign-env)
> @@ -121,10 +121,16 @@ direct descendant of NetBSD's Almquist Shell 
> (@command{ash}).")
>      (arguments
>       '(#:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'set-env
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             ;; some tests write to $HOME
> +             (setenv "HOME" (getcwd))))
>           (add-after 'unpack 'patch-tests
>             (lambda* (#:key inputs #:allow-other-keys)
>               (let ((coreutils (assoc-ref inputs "coreutils"))
>                     (bash (assoc-ref inputs "bash")))
> +               ;; This test fails
> +               (delete-file "tests/checks/pipeline-pgroup.fish")
>                 ;; These try to open a terminal
>                 (delete-file "tests/checks/interactive.fish")
>                 (delete-file "tests/checks/login-interactive.fish")
> -- 
> 2.27.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#42293] [PATCH] gnu: fish: Update to 3.1.2. Date: Sun, 12 Jul 2020 21:58:32 +0300

Looks good. Patch pushed!


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---