emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41897: closed (28.0.50; JavaScript comment filling with mhtml-mode)


From: GNU bug Tracking System
Subject: bug#41897: closed (28.0.50; JavaScript comment filling with mhtml-mode)
Date: Sat, 04 Jul 2020 13:14:02 +0000

Your message dated Sat, 4 Jul 2020 13:13:22 +0000
with message-id <20200704131322.GA19042@ACM>
and subject line Re: bug#41897: 28.0.50; JavaScript comment filling with 
mhtml-mode
has caused the debbugs.gnu.org bug report #41897,
regarding 28.0.50; JavaScript comment filling with mhtml-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41897: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41897
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 28.0.50; JavaScript comment filling with mhtml-mode Date: Tue, 16 Jun 2020 19:08:44 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
In js-mode, the following JavaScript comment is filled as expected when
fill-paragraph (M-q) is used with point within it:

/*
 * This is a long comment that should break over multiple lines when 
fill-paragraph is used.
 */

Is filled as:

/*
 * This is a long comment that should break over multiple lines when
 * fill-paragraph is used.
 */

In mhtml-mode however, the same JavaScript comment:

<html>
  <script>
    /*
     * This is a long comment that should break over multiple lines when 
fill-paragraph is used.
     */
  </script>
</html>

Is filled as:

<html>
  <script>
    /* * This is a long comment that should break over multiple lines
     when fill-paragraph is used.  */
  </script>
</html>



--- End Message ---
--- Begin Message --- Subject: Re: bug#41897: 28.0.50; JavaScript comment filling with mhtml-mode Date: Sat, 4 Jul 2020 13:13:22 +0000
Hello, Simen.

On Mon, Jun 22, 2020 at 19:17:50 +0000, Alan Mackenzie wrote:
> We're gradually converging on working code.  Since yesterday, the
> improvements are:

> (i) (slightly) better handling of auto-fill-mode, which is no longer
> automatically enabled;

> (ii) An enhancement to CC Mode, used by mhtml-mode and js-mode, which
> invalidates a CC Mode cache used by the filling code.  This gets rid of
> a few strange looking bugs;

> (iii) The inclusion of "paragraph-" in the "crucial variables" thing, so
> that paragraph-start and paragraph-separate from js-mode get into
> mhtml-mode.

I've committed more or less the patch from my post of 2020-06-22, which
I'm convinced fixes the bug.  I'm closing the bug with this post.

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]