bug#41849: closed ([PATCH] Add frozen-bubble)

[GNU bug Tracking System]

Your message dated Wed, 17 Jun 2020 12:05:23 +0200
with message-id <87mu529fdo.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#41849] [PATCH] Add frozen-bubble
has caused the debbugs.gnu.org bug report #41849,
regarding [PATCH] Add frozen-bubble
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41849: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41849
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add frozen-bubble Date: Sun, 14 Jun 2020 14:26:41 +0200

Hello,

These three patches add perl-alien-sdl, perl-sdl, and, ultimately,
frozen-bubble.

Feedback welcome,

Regards,
-- 
Nicolas Goaziou

0001-gnu-Add-perl-alien-sdl.patch
Description: Text Data

0002-gnu-Add-perl-sdl.patch
Description: Text Data

0003-gnu-Add-frozen-bubble.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#41849] [PATCH] Add frozen-bubble
>
>
>
>
> Date: 
>
> Wed, 17 Jun 2020 12:05:23 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hello,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Please add a comment stating why we’re pick this revision.
>
> Done.
>
> >> +           (add-after 'unpack 'fix-permissions
> >> +             (lambda _ (invoke "chmod" "-R" "+w" "server")))
> >
> > How about: (for-each make-file-writable
> >                      (find-files "servers" "." #:directories? #t))
>
> OK.
>
> I also removed the #:module-build-flags argument in frozen-bubble
> package, as it didn't seem to be necessary, and I was not sure why I had
> added it in the first place.
>
> > I can’t wait to try it again, so many years later.  :-)
>
> Heh.
>
> Thank you for the review. I pushed the changes.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---