bug#41610: closed ([PATCH] gnu: glade3: Enable tests.)

[GNU bug Tracking System]

Your message dated Tue, 16 Jun 2020 00:10:21 +0530
with message-id <87eeqgnpey.fsf@systemreboot.net>
and subject line Re: [bug#41610] [PATCH] gnu: glade3: Enable tests.
has caused the debbugs.gnu.org bug report #41610,
regarding [PATCH] gnu: glade3: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41610: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41610
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: glade3: Enable tests.
>
>
>
>
> Date: 
>
> Sat, 30 May 2020 03:01:10 +0530
>
>
>
>
> * gnu/packages/gnome.scm (glade3)[arguments]: Enable tests. Add custom
> pre-check phase.
> [native-inputs]: Add hicolor-icon-theme and xorg-server-for-tests.
> ---
>  gnu/packages/gnome.scm | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 1745bf7906..02e14233d1 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -2102,8 +2102,7 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
>                  "023gx8rj51njn8fsb6ma5kz1irjpxi4js0n8rwy22inc4ysldd8r"))))
>      (build-system glib-or-gtk-build-system)
>      (arguments
> -     `(#:tests? #f ; needs X, GL, and software rendering
> -       #:phases
> +     `(#:phases
>         (modify-phases %standard-phases
>           (add-before 'configure 'fix-docbook
>             (lambda* (#:key inputs #:allow-other-keys)
> @@ -2113,18 +2112,27 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
>                                 "/xml/xsl/docbook-xsl-"
>                                 ,(package-version docbook-xsl)
>                                 "/manpages/docbook.xsl")))
> +             #t))
> +         (add-before 'check 'pre-check
> +           (lambda _
> +             (setenv "HOME" "/tmp")
> +             ;; Tests require a running X server.
> +             (system "Xvfb :1 &")
> +             (setenv "DISPLAY" ":1")
>               #t)))))
>      (inputs
>       `(("gtk+" ,gtk+)
>         ("libxml2" ,libxml2)))
>      (native-inputs
> -     `(("intltool" ,intltool)
> +     `(("hicolor-icon-theme" ,hicolor-icon-theme)
> +       ("intltool" ,intltool)
>         ("itstool" ,itstool)
>         ("libxslt" ,libxslt) ;for xsltproc
>         ("docbook-xml" ,docbook-xml-4.2)
>         ("docbook-xsl" ,docbook-xsl)
>         ("python" ,python-2)
> -       ("pkg-config" ,pkg-config)))
> +       ("pkg-config" ,pkg-config)
> +       ("xorg-server" ,xorg-server-for-tests)))
>      (home-page "https://glade.gnome.org";)
>      (synopsis "GTK+ rapid application development tool")
>      (description "Glade is a rapid application development (RAD) tool to
> -- 
> 2.26.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#41610] [PATCH] gnu: glade3: Enable tests. Date: Tue, 16 Jun 2020 00:10:21 +0530

Pushed, thanks for the review!

signature.asc
Description: PGP signature

--- End Message ---