--- Begin Message ---
Subject: |
[PATCH 0/3] Update go-github-com-stretchr-testify |
Date: |
Fri, 22 May 2020 18:04:49 +0200 |
While debugging a test failure of a package I was adding, I have guessed
that the old version of testify is to blame. I was wrong, but since it
takes a bit more than a version bump, perhaps we should upgrade it
anyway?
I have tested building all dependent packages and haven't encountered
any issues.
Jakub Kądziołka (3):
gnu: Add go-github-com-stretchr-objx.
gnu: go-github-com-davecgh-go-spew: Update to 1.1.1.
gnu: go-github-com-stretchr-testify: Update to 1.5.1.
gnu/packages/golang.scm | 114 ++++++++++++++++++++++++----------------
1 file changed, 68 insertions(+), 46 deletions(-)
--
2.26.2
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#41461] [PATCH 1/3] gnu: Add go-github-com-stretchr-objx. |
Date: |
Sun, 7 Jun 2020 21:55:27 +0200 |
On Wed, Jun 03, 2020 at 05:53:49PM +0200, Ludovic Courtès wrote:
> Hello,
>
> Jakub Kądziołka <kuba@kadziolka.net> skribis:
>
> > * gnu/packages/golang.scm (go-github-com-stretchr-objx): New variable.
>
> [...]
>
> > + (synopsis "Go package for dealing with maps, slices, JSON and other
> > data")
> > + (description "Go package for dealing with maps, slices, JSON and other
> > data")
>
> Please write a full sentence (or two :-)) for the description (info
> "(guix) Synopses and Descriptions").
>
> Otherwise the three patches LGTM!
Thanks for your review! I wrote a fuller description and pushed the
patches.
Regards,
Jakub Kądziołka
signature.asc
Description: PGP signature
--- End Message ---