--- Begin Message ---
|
Subject: |
[PATCH] gnu: Add emacs-flymake-shellcheck. |
|
Date: |
Fri, 5 Jun 2020 16:33:49 -0700 |
* gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable.
---
gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6110374281..73d030f239 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -992,6 +992,34 @@ different tools. It highlights errors and warnings inline
in the buffer, and
provides an optional IDE-like error list.")
(license license:gpl3+)))) ;+GFDLv1.3+ for the manual
+(define-public emacs-flymake-shellcheck
+ ;; No tag, version grabbed from source .el file.
+ (let ((commit "78956f0e5bb9c4d35989657a55929e8e3f5691e6")
+ (revision "0"))
+ (package
+ (name "emacs-flymake-shellcheck")
+ (version (git-version "0.1" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/federicotdn/flymake-shellcheck.git";)
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "068mx5p4drwgppy4ry1rfq6qi79w6d82b4rnpl2jm37grsg94lix"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("shellcheck" ,shellcheck)))
+ (home-page "https://github.com/federicotdn/flymake-shellcheck";)
+ (synopsis "Flymake backend for Bash/Sh powered by ShellCheck")
+ (description
+ "This package provides a backend for Flymake (emacs-26+) to use the
+tool @command{shellcheck} for static analyzing @command{bash} and @command{sh}
+scripts. Please see the description on @command{shellcheck} for more
+information on what it can do.")
+ (license license:gpl3+))))
+
(define-public emacs-a
(package
(name "emacs-a")
--
2.26.2
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck. |
|
Date: |
Sun, 07 Jun 2020 21:22:53 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Fredrik Salomonsson via web <issues.guix.gnu.org@elephly.net> writes:
> I was debating to myself whether to include shellcheck or not. As when
> I looked around in emacs-xyz.scm, for example `emacs-ag' does
> propagate the-silver-searcher but `emacs-direnv' does not.
emacs-ag package contains a comment explaining why the propagated inputs
is required.
Sometimes, it is unavoidable, but usage of propagated-inputs should be
as limited as possible.
> Anyway, I removed it in the latest patch.
Thank you. I applied your patch.
Regards,
--
Nicolas Goaziou
--- End Message ---