bug#41636: closed ([PATCH] combinators: Recurse fold2 to named let loop.)

[GNU bug Tracking System]

Your message dated Mon, 1 Jun 2020 14:58:26 +0200
with message-id <20200601125826.2m7xnnzy2kogvbo7@gravity>
and subject line Re: [PATCH] combinators: Recurse fold2 to named let loop.
has caused the debbugs.gnu.org bug report #41636,
regarding [PATCH] combinators: Recurse fold2 to named let loop.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41636: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41636
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] combinators: Recurse fold2 to named let loop.
>
>
>
>
> Date: 
>
> Mon,  1 Jun 2020 05:41:13 +0530
>
>
>
>
> * guix/combinators.scm (fold2): Recurse to named let loop, not fold2 itself.
> ---
>  guix/combinators.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/combinators.scm b/guix/combinators.scm
> index 11cad62ccf..4707b59363 100644
> --- a/guix/combinators.scm
> +++ b/guix/combinators.scm
> @@ -1,6 +1,7 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès 
> <ludo@gnu.org>
>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> +;;; Copyright © 2020 Arun Isaac <arunisaac@systemreboot.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -56,7 +57,7 @@
>             (call-with-values
>                 (lambda () (proc (car lst1) (car lst2) result1 result2))
>               (lambda (result1 result2)
> -               (fold2 proc result1 result2 (cdr lst1) (cdr lst2)))))))))
> +               (loop result1 result2 (cdr lst1) (cdr lst2)))))))))
>  
>  (define (fold-tree proc init children roots)
>    "Call (PROC NODE RESULT) for each node in the tree that is reachable from
> -- 
> 2.26.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH] combinators: Recurse fold2 to named let loop. Date: Mon, 1 Jun 2020 14:58:26 +0200

On Mon, Jun 01, 2020 at 05:41:13AM +0530, Arun Isaac wrote:
> * guix/combinators.scm (fold2): Recurse to named let loop, not fold2 itself.
> ---
>  guix/combinators.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks for the patch! I agree that this is better for consistency, thus
I have pushed your patch as commit 7a99c58c4597a550703f32018efafb0fe84d5c72.

Cheers!

signature.asc
Description: PGP signature

--- End Message ---