emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39786: closed ([PATCH] Add dragonfly-reverb.)


From: GNU bug Tracking System
Subject: bug#39786: closed ([PATCH] Add dragonfly-reverb.)
Date: Sat, 21 Mar 2020 20:56:02 +0000

Your message dated Sat, 21 Mar 2020 21:55:33 +0100
with message-id <address@hidden>
and subject line Re: [bug#39786] [PATCH] Add dragonfly-reverb.
has caused the debbugs.gnu.org bug report #39786,
regarding [PATCH] Add dragonfly-reverb.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39786: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39786
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Add dragonfly-reverb. Date: Tue, 25 Feb 2020 15:20:12 +0000 User-agent: Evolution 3.32.4
Hi,

This patch adds dragonfly reverb, a popular reverb plugin.

Unfortunately it doesn't have an install target so I resorted to
copying the files manually.

Thanks,
Alex

Attachment: 0001-gnu-Add-dragonfly-reverb.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- Subject: Re: [bug#39786] [PATCH] Add dragonfly-reverb. Date: Sat, 21 Mar 2020 21:55:33 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hello,

Alexandros Theodotou <address@hidden> writes:

> Attaching the updated patch. I also removed some unneeded
> dependencies.

Thank you! I applied your patch, with the following changes :

> +(define-public dragonfly-reverb

I fixed the indentation, which was a bit off,

> +           (lambda* (#:key inputs outputs #:allow-other-keys)

I removed `inputs' as it was not needed.

> +    (synopsis "Concert hall reverb and room reverb effects")
> +    (description
> +     "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb.  Both are available as LV2 plugins as well
> +as JACK standalone applications.")
> +    (home-page "https://michaelwillis.github.io/dragonfly-reverb/";)

I moved `home-page' above `synopsis'.

Regards,

-- 
Nicolas Goaziou


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]