--- Begin Message ---
Subject: |
[PATCH 0/3] WIP: Hyperledger Iroha |
Date: |
Fri, 6 Mar 2020 10:23:22 +0100 |
It's close to build but fails with some unreadable C++ / Boost error.
I've reported upstream:
https://jira.hyperledger.org/browse/IR-689?jql=text%20~%20%22guix%22
Anyone proficient enough in C++ / Boost to solve this?
Pierre Neidhardt (3):
gnu: Add fmt-5.
gnu: Add hyperledger-iroha-ed25519.
gnu: Add hyperledger-iroha.
gnu/packages/hyperledger.scm | 125 +++++++++++++++++-
...oha-ed25519-cmake-remove-hunter-gate.patch | 23 ++++
gnu/packages/pretty-print.scm | 14 ++
3 files changed, 157 insertions(+), 5 deletions(-)
create mode 100644
gnu/packages/patches/hyperledger-iroha-ed25519-cmake-remove-hunter-gate.patch
--
2.25.1
--- End Message ---
--- Begin Message ---
Subject: |
Re: [PATCH v2 4/4] gnu: Add hyperledger-iroha. |
Date: |
Thu, 12 Mar 2020 15:40:55 +0200 |
On Wed, Mar 11, 2020 at 03:13:25PM +0100, Pierre Neidhardt wrote:
> I've tested it and run the example here
> https://iroha.readthedocs.io/en/latest/getting_started/cli-guide.html
> It works!
>
> Patch looks good, feel free to merge.
> A few comments below:
>
> > + (snippet
> > + '(begin
> > + ;; Backport unversioned fmt dependency:
> > + (substitute* "libs/logger/logger.hpp"
> > + (("fmt::v5") "fmt"))
> > + #t))))
>
> Mention the commit you've sent me and that this should be removed on
> next update.
Done
>
> > + (build-system cmake-build-system)
> > + (arguments
> > + `(#:configure-flags
> > + '("-DTESTING=OFF"
> > + ; Don't install the shared libraries of the dependencies:
> > + "-DENABLE_LIBS_PACKAGING=OFF")
> > + #:tests? #f
>
> Explain why the tests must be disabled.
>
Noted
> > + #:test-target "."
>
> Why setting the test-target if you are not running it?
>
I added a note to the build instructions, for when we can run the tests
> > + #:phases
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'change-compilation-flags
> > + (lambda _
> > + (substitute* "cmake/functions.cmake"
> > + (("-Werror") ""))
> > + #t)))))
>
> Why do you need to do this?
>
Turns out we don't, I removed it
> > + ;; See https://iroha.readthedocs.io/en/latest/build/index.html.
> > + (native-inputs
> > + `(("googletest" ,googletest)))
> > + (inputs
> > + `(("boost" ,boost-1.69)
> > + ("fmt" ,fmt)
> > + ("gflags" ,gflags)
> > + ("grpc" ,grpc)
> > + ("hyperledger-iroha-ed25519" ,hyperledger-iroha-ed25519)
> > + ("postgresql" ,postgresql)
> > + ("protobuf" ,protobuf)
> > + ("rapidjson" ,rapidjson)
> > + ("rxcpp" ,rxcpp)
> > + ("soci" ,soci)
> > + ("spdlog" ,spdlog)
> > + ("tbb" ,tbb)))
> > + (synopsis "Simple, decentralized ledger")
> > + (description "Iroha is a distributed ledger technology (DLT). Iroha has
>
> Double spacing.
>
> Thanks!
> Cheers!
>
> --
> Pierre Neidhardt
> https://ambrevar.xyz/
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
--- End Message ---