bug#39932: closed ([PATCH 0/3] python-virtualenv: Update to 20.0.8.)

[GNU bug Tracking System]

Your message dated Mon, 9 Mar 2020 00:22:57 +0100
with message-id <20200308232257.pcwhhzzgetzomayy@gravity>
and subject line Re: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add 
python-distlib.
has caused the debbugs.gnu.org bug report #39932,
regarding [PATCH 0/3] python-virtualenv: Update to 20.0.8.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39932: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39932
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] python-virtualenv: Update to 20.0.8.
>
>
>
>
> Date: 
>
> Thu,  5 Mar 2020 20:14:24 +0100
>
>
>
>
> I have ran into an issue with virtualenv (see #39930). I have thought
> that updating the package might help, but it didn't change anything. Either
> way, the task was non-trivial enough to benefit from your review.
>
> Jakub Kądziołka (3):
>   gnu: python-xyz: Add python-distlib.
>   gnu: python-xyz: Add python-filelock.
>   gnu: python-virtualenv: Update to 20.0.8.
>
>  gnu/packages/python-xyz.scm | 80 +++++++++++++++++++++++++++++++------
>  1 file changed, 67 insertions(+), 13 deletions(-)
>
> -- 
> 2.25.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib. Date: Mon, 9 Mar 2020 00:22:57 +0100

On Sun, Mar 08, 2020 at 09:18:12PM +0100, Ludovic Courtès wrote:
> Hello,
> 
> Jakub Kądziołka <address@hidden> skribis:
> 
> > * gnu/packages/python-xyz.scm (python-distlib): New variable.
> 
> [...]
> 
> > +       (modify-phases %standard-phases
> > +         (add-before 'build 'no-/bin/sh
> > +           (lambda _
> > +             (substitute* '("distlib/scripts.py" "tests/test_scripts.py")
> > +               (("/bin/sh") (which "sh")))))
> > +         (add-before 'check 'prepare-test-env
> > +           (lambda _
> > +             (setenv "HOME" "/tmp")
> > +             ;; NOTE: Any value works, the variable just has to be present.
> > +             (setenv "SKIP_ONLINE" "1"))))))
> 
> Please return #t from both phases, as is conventional.
Argh, I'm always forgetting about that. It would be nice to have a lint
for this...

> Apart from that, all 3 patches LGTM!
Thanks! I pushed the commits, the last one got a hash of
94d57ba3399aeb1b34d52e5e866c609f5a18ec2b

signature.asc
Description: PGP signature

--- End Message ---