bug#38851: closed (27.0.50; Recent my patch breaks isearch with macOS native input method)

[GNU bug Tracking System]

Your message dated Wed, 19 Feb 2020 11:14:20 +0000
with message-id <address@hidden>
and subject line Re: bug#38851: 27.0.50; Recent my patch breaks isearch with 
macOS native input method
has caused the debbugs.gnu.org bug report #38851,
regarding 27.0.50; Recent my patch breaks isearch with macOS native input method
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38851: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38851
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 27.0.50; Recent my patch breaks isearch with macOS native input method Date: Thu, 2 Jan 2020 03:25:13 +0900

I sent a patch for Bug#23412 and the patch was already merged.
(http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=ba042176d8931cdf9441b3b4919ec74b75019494)

Unfortunately, the patch breaks isearch with macOS native input method.
I tried to modify ns-echo-working-text function and ns-delete-working-text
function, but I cannot do it.
This is because input-pending-p now returns t after pressing RET to confirm 
the conversion. (isearch-update function uses input-pending-p)

The following patch treats ns-unput-working-text event by deleteWorkingText 
specially in read_char(). This solve the problem.

0001-Change-redisplay-solution.patch
Description: Binary data

--
tsuucat

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#38851: 27.0.50; Recent my patch breaks isearch with macOS native input method
>
>
>
>
> Date: 
>
> Wed, 19 Feb 2020 11:14:20 +0000
>
>
>
>
> On Fri, Feb 14, 2020 at 04:17:29AM +0900, tsuucat wrote:
> > 
> > > Please squash your three new patches together and have a look at the
> > > instructions in CONTRIBUTE regarding commit messages.
> > 
> > OK. I squashed patches and attach the patch. Please tell me if there’s 
> > something wrong.
>
> Everything looks good to me, thank you. I’ve pushed to master.
> -- 
> Alan Third
>
>
> --- End Message ---