bug#39457: closed (Fix baud-rate option in inputattach-service)

[GNU bug Tracking System]

Your message dated Fri, 07 Feb 2020 11:54:15 +0800
with message-id <address@hidden>
and subject line Re: [bug#39457] Fix baud-rate option in inputattach-service
has caused the debbugs.gnu.org bug report #39457,
regarding Fix baud-rate option in inputattach-service
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39457: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39457
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Fix baud-rate option in inputattach-service
>
>
>
>
> Date: 
>
> Thu, 06 Feb 2020 19:37:32 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.2.0; emacs 26.3
>
>
>
>
> Hi,
>
> the "baud-rate" option for inputattach-service is broken, the
> inputattach program expects the option to be named just "--baud".
> The attached patch fixes the issue.
>
> Just out of interest: Should we stick in Guix to the option used by the
> program or stick with the old name?
> I would like to keep the "baud-rate" name as it is the thing the
> parameter configures: The baud-rate for the connection.
>
> Tim.
>
> >From 223608191ba3587b1e9f1e1257d482dc89c59709 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <address@hidden>
> Date: Thu, 6 Feb 2020 19:26:03 +0100
> Subject: [PATCH] services: inputattach: Fix broken baud rate option
>
> * gnu/services/desktop.scm (inputattach-shepherd-service): Use "--baud" for
>   setting the baud-rate.
> ---
>  gnu/services/desktop.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 9dcdf38be1..1294d748ac 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -1070,7 +1070,7 @@ as expected.")))
>    (match-lambda
>      (($ <inputattach-configuration> type device baud-rate log-file)
>       (let ((args (append (if baud-rate
> -                             (list "--baud-rate" (number->string baud-rate))
> +                             (list "--baud" (number->string baud-rate))
>                               '())
>                           (list (string-append "--" type)
>                                 device))))
> -- 
> 2.25.0
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#39457] Fix baud-rate option in inputattach-service
>
>
>
>
> Date: 
>
> Fri, 07 Feb 2020 11:54:15 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Tim Gesthuizen <address@hidden> writes:
>
> > Hi,
> >
> > the "baud-rate" option for inputattach-service is broken, the
> > inputattach program expects the option to be named just "--baud".
> > The attached patch fixes the issue.
>
> Pushed, thank you!
>
> >
> > Just out of interest: Should we stick in Guix to the option used by the
> > program or stick with the old name?
> > I would like to keep the "baud-rate" name as it is the thing the
> > parameter configures: The baud-rate for the connection.
> >
>
> I think both are fine, as we document it in our info manual.
>
> :)
>
>
> --- End Message ---