bug#39428: closed (28.0.50; cl--push-clause-loop-body: eval macro arg just once)

[GNU bug Tracking System]

Your message dated Wed, 05 Feb 2020 19:08:42 +0100
with message-id <address@hidden>
and subject line Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro 
arg just once
has caused the debbugs.gnu.org bug report #39428,
regarding 28.0.50; cl--push-clause-loop-body: eval macro arg just once
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
39428: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39428
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 28.0.50; cl--push-clause-loop-body: eval macro arg just once
>
>
>
>
> Date: 
>
> Tue, 04 Feb 2020 22:05:30 +0100
>
>
>
>
> X-Debbugs-Cc: Stefan Monnier <address@hidden>,address@hidden
>
> I think this little tweak has sense.  WDYT?
>
>
> --8<-----------------------------cut here---------------start------------->8---
> commit eb88afb89a8cfb760d89569e74c8ece1d1c446cb
> Author: Tino Calancha <address@hidden>
> Date:   Tue Feb 4 21:52:06 2020 +0100
>
>     Eval macro arg just once
>     
>     * lisp/emacs-lisp/cl-macs.el (cl--push-clause-loop-body):
>     Use `macroexp-let2'.
>
> diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
> index 9d0fd15bc3..4c2f58907d 100644
> --- a/lisp/emacs-lisp/cl-macs.el
> +++ b/lisp/emacs-lisp/cl-macs.el
> @@ -1037,9 +1037,10 @@ cl-loop
>  
>  (defmacro cl--push-clause-loop-body (clause)
>    "Apply CLAUSE to both `cl--loop-conditions' and `cl--loop-body'."
> -  `(progn
> -     (push ,clause cl--loop-conditions)
> -     (push ,clause cl--loop-body)))
> +  (macroexp-let2 nil sym clause
> +    `(progn
> +       (push ,sym cl--loop-conditions)
> +       (push ,sym cl--loop-body))))
>  
>  ;; Below is a complete spec for cl-loop, in several parts that correspond
>  ;; to the syntax given in CLtL2.  The specs do more than specify where
>
> --8<-----------------------------cut here---------------end--------------->8---
>
>
> In GNU Emacs 28.0.50 (build 21, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo 
> version 1.16.0)
>  of 2020-02-04 built on calancha-pc.dy.bbexcite.jp
> Repository revision: e287da5a8154d83a97107b64915ccc17e3a086b8
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
> System Description: Debian GNU/Linux 10 (buster)
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once
>
>
>
>
> Date: 
>
> Wed, 05 Feb 2020 19:08:42 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> address@hidden writes:
>
> > LGTM, thanks.
>
> Pushed at master branch as commit 'Eval macro arg just once'
> (ebff24c0b8fa54854fe8445f2eba1d99fb76ecf2)
>
>
> --- End Message ---