[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#38460: closed ([PATCH 0/1] lint: Add '--load-path' option.)

From: GNU bug Tracking System
Subject: bug#38460: closed ([PATCH 0/1] lint: Add '--load-path' option.)
Date: Sun, 08 Dec 2019 14:19:01 +0000

Your message dated Sun, 08 Dec 2019 15:17:44 +0100
with message-id <address@hidden>
and subject line Re: [bug#38460] [PATCH 1/1] lint: Add '--load-path' option.
has caused the debbugs.gnu.org bug report #38460,
regarding [PATCH 0/1] lint: Add '--load-path' option.
to be marked as done.

(If you believe you have received this mail in error, please contact

38460: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38460
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH 0/1] lint: Add '--load-path' option. Date: Mon, 2 Dec 2019 21:47:59 +0100

Currently, when developing personal packages, "guix lint" needs the variable 
GUIX_PACKAGE_PATH which is not user friendly, IMO. The patch uses the common 
option '-L' to prepend a load path.

Other said,

  GUIX_PACKAGE_PATH=/path/to/my/package guix lint foo


  guix lint -L /path/to/my/package foo

All the best,

zimoun (1):
  lint: Add '--load-path' option.

 guix/scripts/lint.scm |  8 ++++++++
 tests/guix-lint.sh    | 12 ++++++++++++
 2 files changed, 20 insertions(+)


--- End Message ---
--- Begin Message --- Subject: Re: [bug#38460] [PATCH 1/1] lint: Add '--load-path' option. Date: Sun, 08 Dec 2019 15:17:44 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

zimoun <address@hidden> skribis:

> On Sat, 7 Dec 2019 at 23:51, Ludovic Courtès <address@hidden> wrote:
>> Well, technically speaking it’s not copy/pasted since the code you sent
>> uses ‘find’ to grab the option; plus, we’re talking about very few
>> lines, which is typically hard to factorize.
> I agree. Even if I do not have a better solution to propose, I just
> feel the current one is not optimal.
> Does the same gettext entries G_ are duplicated? Do translators
> translate 2 times (or more) the same string?

No, they’re deduplicated.

>> So I sympathize with the bad feeling of repetition, but I’m not quite
>> sure how this can be avoided in this case.
>> WDYT?
> Thank you for the explanations. I am not sure neither and need to fail
> by myself to be convinced. ;-)
> And currently, any hypothetical break should be reported by the test
> suite. Hope so.

I think so.

I’ve applied it now, thank you!


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]