bug#38240: closed ([PATCH] services: sysctl: Make service one-shot.)

[GNU bug Tracking System]

Your message dated Wed, 20 Nov 2019 21:24:52 +0200
with message-id <20191120192452.GU15074@E5400>
and subject line Re: [bug#38240] [PATCH v3] services: sysctl: Make service 
one-shot.
has caused the debbugs.gnu.org bug report #38240,
regarding [PATCH] services: sysctl: Make service one-shot.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38240: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38240
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: sysctl: Make service one-shot.
>
>
>
>
> Date: 
>
> Sat, 16 Nov 2019 23:42:06 +0200
>
>
>
>
> * gnu/services/sysctl.scm (sysctl-shepherd-service): Adjust shepherd
> service to use '--one-shot' flag. Remove 'respawn' option.
> ---
>  gnu/services/sysctl.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/services/sysctl.scm b/gnu/services/sysctl.scm
> index 5e9e6f0661..1f1cf38195 100644
> --- a/gnu/services/sysctl.scm
> +++ b/gnu/services/sysctl.scm
> @@ -58,9 +58,8 @@
>          (documentation "Configure kernel parameters at boot.")
>          (provision '(sysctl))
>          (start #~(lambda _
> -                   (zero? (system* #$sysctl "--load" #$sysctl.conf))))
> -        (stop #~(const #t))
> -        (respawn? #f))))))
> +                   (zero? (system* #$sysctl "--load" #$sysctl.conf 
> "--one-shot"))))
> +        (stop #~(const #t)))))))
>  
>  (define sysctl-service-type
>    (service-type
> -- 
> 2.24.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#38240] [PATCH v3] services: sysctl: Make service one-shot. Date: Wed, 20 Nov 2019 21:24:52 +0200 User-agent: Mutt/1.12.2 (2019-09-21)

On Wed, Nov 20, 2019 at 03:10:57PM +0100, Ludovic Courtès wrote:
> Hello!
> 
> Efraim Flashner <address@hidden> skribis:
> 
> > From 796bf6d1b58d675b04198e536bae62552b16da75 Mon Sep 17 00:00:00 2001
> > From: Efraim Flashner <address@hidden>
> > Date: Sat, 16 Nov 2019 23:33:31 +0200
> > Subject: [PATCH] services: sysctl: Make service one-shot.
> >
> > * gnu/services/sysctl.scm (sysctl-shepherd-service): Adjust shepherd
> > service to use the 'one-shot?' keyword. Remove 'stop' command. Remove
> > 'respawn' option.
> > ---
> >  gnu/services/sysctl.scm | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/services/sysctl.scm b/gnu/services/sysctl.scm
> > index 5e9e6f0661..2110b80395 100644
> > --- a/gnu/services/sysctl.scm
> > +++ b/gnu/services/sysctl.scm
> > @@ -58,9 +58,8 @@
> >          (documentation "Configure kernel parameters at boot.")
> >          (provision '(sysctl))
> >          (start #~(lambda _
> > -                   (zero? (system* #$sysctl "--load" #$sysctl.conf))))
> > -        (stop #~(const #t))
> > -        (respawn? #f))))))
> > +                   (invoke #$sysctl "--load" #$sysctl.conf)))
> > +        (one-shot? #t))))))
> 
> Perhaps we’d rather keep the (zero? (system* …)) idiom here, so that
> ‘herd start’ gracefully reports failure of ‘sysctl’.

I didn't think that'd be a problem.

> 
> Apart from that, it’s all good to me!  :-)
> 
> Ludo’.

Ok, patch pushed!

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---