bug#38219: closed (Error on leaving Ediff after killing vital buffer)

[GNU bug Tracking System]

Your message dated Mon, 18 Nov 2019 23:53:29 +0200
with message-id <address@hidden>
and subject line Re: bug#38219: Error on leaving Ediff after killing vital 
buffer
has caused the debbugs.gnu.org bug report #38219,
regarding Error on leaving Ediff after killing vital buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38219: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38219
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Error on leaving Ediff after killing vital buffer Date: Fri, 15 Nov 2019 13:50:32 +0000

If you kill one of Ediff's vital buffers, then try to leave Ediff (by typing q in the control window), there is an error.

The error is:
ediff-visible-region: You have killed a vital Ediff buffer---you must leave Ediff now!

Recipe from 'emacs -Q' (Windows GUI build):

* Visit a file under version control with unstaged changes.
* [M-x ediff-revision RET RET RET RET]
* In the main frame, kill one of the buffers being diffed
* In the Ediff control window frame, type [q y]

Bisected to this commit:

a26a8cc1c85f29fb11209c16d53a8ae4e4ab7ced
Author: Juri Linkov <address@hidden>
Date: Sun Nov 10 00:04:13 2019 +0200

'y-or-n-p' now uses the minibuffer to read 'y' or 'n' answer (bug#38076)

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#38219: Error on leaving Ediff after killing vital buffer
>
>
>
>
> Date: 
>
> Mon, 18 Nov 2019 23:53:29 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
>
>
>
>
> >> You could argue that 'ediff' already breaks
> >>
> >> (defalias 'y-or-n-p 'yes-or-no-p)
> >>
> >> They would probably say that consulting 'this-command' after a
> >> 'y-or-n-p' "has worked ever since".  Guess whose argument wins.
> >
> > Good example.  This means that 'ediff' is broken, here is the fix:
>
> Now pushed and closed. 
>
>
> --- End Message ---