bug#36603: closed ([PATCH] Simplify calling convention of describe_map)

[GNU bug Tracking System]

Your message dated Mon, 11 Nov 2019 19:44:29 +0100
with message-id <address@hidden>
and subject line Re: bug#36603: [PATCH] Simplify calling convention of 
describe_map
has caused the debbugs.gnu.org bug report #36603,
regarding [PATCH] Simplify calling convention of describe_map
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36603: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36603
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Simplify calling convention of describe_map
>
>
>
>
> Date: 
>
> Thu, 11 Jul 2019 19:34:22 +0200
>
>
>
>
> This patch simplifies the calling convention of describe_map in
> keymap.c.
>
> The immediate motivation is to simplify a set of patches that I'm
> preparing for Bug#8951 to rewrite substitute-command-keys in Lisp.
> But I think this makes sense in any case.
>
> (I'll send the patch in a separate message once this is assigned a bug
> number.)
>
> Thanks,
> Stefan Kangas
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#36603: [PATCH] Simplify calling convention of describe_map
>
>
>
>
> Date: 
>
> Mon, 11 Nov 2019 19:44:29 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
>
>
>
>
> Stefan Kangas <address@hidden> writes:
>
> >> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
> >> has describe_map start with a fresh seen pointer each time; but the
> >> current code passes the same pointer to each describe_map call in a
> >> loop.
> >
> > Thanks for that feedback.  I'll take another look and get back to you.
>
> I think your analysis is correct Noam, and I'm working on a different
> approach here, although this project is has been put on the
> back-burner for now.  I'll get back into it once I can finish up some
> other things first.
>
> Thanks for taking the time to review this.  Closing this bug report.
>
> Best regards,
> Stefan Kangas
>
>
> --- End Message ---