emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#37392: closed ([PATCH] gnu: Add r-assertr)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#37392: closed ([PATCH] gnu: Add r-assertr)
Date: Thu, 12 Sep 2019 23:10:02 +0000

Your message dated Fri, 13 Sep 2019 01:09:43 +0200
with message-id <address@hidden>
and subject line Re: [bug#37392] [PATCH] gnu: Add r-assertr
has caused the debbugs.gnu.org bug report #37392,
regarding [PATCH] gnu: Add r-assertr
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37392: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37392
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] gnu: Add r-assertr Date: Thu, 12 Sep 2019 18:44:57 +0200
From: Wiktor Żelazny <address@hidden>

* gnu/packages/cran.scm (r-assertr): New variable
---
 gnu/packages/cran.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 6ef2066429..ddaffb6b6d 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2018 Marius Bakke <address@hidden>
 ;;; Copyright © 2018, 2019 Brett Gilio <address@hidden>
 ;;; Copyright © 2019 Nicolò Balzarotti <address@hidden>
+;;; Copyright © 2019 Wiktor Żelazny <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -15365,3 +15366,29 @@ common graph algorithms.")
 removing cell free mRNA contamination (the \"soup\") from droplet based single
 cell RNA-seq experiments.")
       (license license:gpl2))))
+
+(define-public r-assertr
+  (package
+    (name "r-assertr")
+    (version "2.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "assertr" version))
+       (sha256
+        (base32
+         "0g4ii6vhp0155a29ljhs64a09x0nzy5ybvwwchhk4mkcgsvnvfkj"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-dplyr" ,r-dplyr)
+       ("r-knitr" ,r-knitr)             ; needed for vignette
+       ("r-mass" ,r-mass)
+       ("r-rlang" ,r-rlang)))
+    (home-page "https://github.com/ropensci/assertr";)
+    (synopsis "Assertive Programming for R Analysis Pipelines")
+    (description
+     "Provides functionality to assert conditions that have to be met so that
+errors in data used in analysis pipelines can fail quickly.  Similar to
+@code{stopifnot()} but more powerful, friendly, and easier for use in
+pipelines.")
+    (license (license:fsf-free 
"https://cran.r-project.org/web/licenses/MIT";))))
-- 
2.22.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#37392] [PATCH] gnu: Add r-assertr Date: Fri, 13 Sep 2019 01:09:43 +0200 User-agent: mu4e 1.2.0; emacs 26.2
Hi Wiktor,

> * gnu/packages/cran.scm (r-assertr): New variable

Thank you for your patch!

I made a couple of minor changes before pushing it to the repository’s
master branch.

> +(define-public r-assertr
> +  (package
> +    (name "r-assertr")
> +    (version "2.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "assertr" version))
> +       (sha256
> +        (base32
> +         "0g4ii6vhp0155a29ljhs64a09x0nzy5ybvwwchhk4mkcgsvnvfkj"))))
> +    (build-system r-build-system)
> +    (propagated-inputs
> +     `(("r-dplyr" ,r-dplyr)
> +       ("r-knitr" ,r-knitr)             ; needed for vignette

I moved this to native-inputs, because it is not needed at runtime.

> +    (synopsis "Assertive Programming for R Analysis Pipelines")

I changed this to use lower case.

> +    (description
> +     "Provides functionality to assert conditions that have to be met so that
> +errors in data used in analysis pipelines can fail quickly.  Similar to
> +@code{stopifnot()} but more powerful, friendly, and easier for use in
> +pipelines.")

I used full sentences here.

> +    (license (license:fsf-free 
> "https://cran.r-project.org/web/licenses/MIT";))))

This is the Expat license, so I changed it to license:expat.

I also added punctuation to the commit message.

Thank you for your contribution and welcome to Guix!

-- 
Ricardo



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]