[debbugs-tracker] bug#37302: closed ([PATCH 0/7] Remove the daemon's libexec helpers)

[GNU bug Tracking System]

Your message dated Sun, 08 Sep 2019 12:03:46 +0200
with message-id <address@hidden>
and subject line Re: [bug#37302] [PATCH 0/7] Remove the daemon's libexec helpers
has caused the debbugs.gnu.org bug report #37302,
regarding [PATCH 0/7] Remove the daemon's libexec helpers
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37302: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37302
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/7] Remove the daemon's libexec helpers
>
>
>
>
> Date: 
>
> Wed,  4 Sep 2019 12:19:35 +0200
>
>
>
>
> Hello Guix!
>
> These patches change the daemon so that it invokes ‘guix substitute’,
> ‘guix authenticate’, etc. directly, instead of invoking the shell
> trampolines under libexec/.
>
> This simplifies things a bit, gets rid of the extra Bash invocation,
> which in turn makes sure that we don’t get locale warnings from
> Bash, should that happen.  :-)
>
> Initially the libexec trampolines were created primarily so that the
> C++ code would remain as close as possible to upstream Nix.  The cost
> of this strategy have come to outweigh the benefits, so here we go!
>
> The next step will be to adjust the ‘guix’ and ‘guix-daemon’ packages
> accordingly.
>
> Feedback welcome!
>
> Ludo’.
>
> Ludovic Courtès (7):
>   daemon: Invoke 'guix gc --list-busy' instead of 'list-runtime-roots'.
>   daemon: Run 'guix authenticate' directly.
>   daemon: Run 'guix perform-download' directly.
>   daemon: Run 'guix offload' directly.
>   daemon: Run 'guix substitute' directly and assume a single
>     substituter.
>   daemon: Remove 'NIX_LIBEXEC_DIR'.
>   etc: Remove references to libexec/guix* from SELinux policy.
>
>  build-aux/pre-inst-env.in         |  14 +--
>  config-daemon.ac                  |  11 ---
>  doc/guix.texi                     |   4 +
>  etc/guix-daemon.cil.in            |   4 -
>  guix/scripts/gc.scm               |  15 +++
>  guix/store/roots.scm              | 129 +++++++++++++++++++++++++-
>  nix/libstore/build.cc             |  63 +++++--------
>  nix/libstore/builtins.cc          |   4 +-
>  nix/libstore/gc.cc                |  11 +--
>  nix/libstore/globals.cc           |   2 +-
>  nix/libstore/globals.hh           |  11 +--
>  nix/libstore/local-store.cc       | 102 ++++++++++++---------
>  nix/libstore/local-store.hh       |  12 +--
>  nix/local.mk                      |  16 ----
>  nix/nix-daemon/guix-daemon.cc     |  20 +---
>  nix/nix-daemon/nix-daemon.cc      |  16 +++-
>  nix/scripts/authenticate.in       |  11 ---
>  nix/scripts/download.in           |  11 ---
>  nix/scripts/list-runtime-roots.in | 147 ------------------------------
>  nix/scripts/offload.in            |  11 ---
>  nix/scripts/substitute.in         |  11 ---
>  21 files changed, 260 insertions(+), 365 deletions(-)
>  delete mode 100644 nix/scripts/authenticate.in
>  delete mode 100644 nix/scripts/download.in
>  delete mode 100644 nix/scripts/list-runtime-roots.in
>  delete mode 100644 nix/scripts/offload.in
>  delete mode 100644 nix/scripts/substitute.in
>
> -- 
> 2.23.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#37302] [PATCH 0/7] Remove the daemon's libexec helpers
>
>
>
>
> Date: 
>
> Sun, 08 Sep 2019 12:03:46 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Ludovic Courtès <address@hidden> skribis:
>
> >   daemon: Invoke 'guix gc --list-busy' instead of 'list-runtime-roots'.
> >   daemon: Run 'guix authenticate' directly.
> >   daemon: Run 'guix perform-download' directly.
> >   daemon: Run 'guix offload' directly.
> >   daemon: Run 'guix substitute' directly and assume a single
> >     substituter.
> >   daemon: Remove 'NIX_LIBEXEC_DIR'.
> >   etc: Remove references to libexec/guix* from SELinux policy.
>
> Pushed at cc98b00857e29074de96a6ed60e325cdfffaea1a.
>
> Now to adjust ‘guix-daemon’ accordingly…
>
> Ludo’.
>
>
> --- End Message ---