[debbugs-tracker] bug#37046: closed (mod-test-add-nanosecond/valid fails)

[GNU bug Tracking System]

Your message dated Fri, 16 Aug 2019 16:54:17 -0700
with message-id <address@hidden>
and subject line Re: bug#37046: mod-test-add-nanosecond/valid fails
has caused the debbugs.gnu.org bug report #37046,
regarding mod-test-add-nanosecond/valid fails
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37046: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37046
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> mod-test-add-nanosecond/valid fails
>
>
>
>
> Date: 
>
> Fri, 16 Aug 2019 01:40:49 -0400
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Package: emacs
> Severity: minor
> Version: 27.0.50
>
> Somewhere between 3548fd8 and 96ef76e (inclusive),
> mod-test-add-nanosecond/valid began failing.
>
> Ref eg
> https://hydra.nixos.org/build/98764057
> https://hydra.nixos.org/build/98750439
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#37046: mod-test-add-nanosecond/valid fails Date: Fri, 16 Aug 2019 16:54:17 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Glenn Morris wrote:

Package: emacs
Severity: minor
Version: 27.0.50

Somewhere between 3548fd8 and 96ef76e (inclusive),
mod-test-add-nanosecond/valid began failing.

Ref eg
https://hydra.nixos.org/build/98764057
https://hydra.nixos.org/build/98750439

Thanks for reporting that. It should be fixed by commit 2019-08-16T23:25:02Z!address@hidden (attached) so I'm boldly closing the bug report.

On a related topic, perhaps tests shouldn't depend on time-of-day? That kind of phase-of-the-moon stuff can make maintenance difficult - though, as it happened, it wasn't a problem this time as I discovered and fixed the bug before reading your bug report.

0001-Fix-time-add-rounding-bug.patch
Description: Text Data

--- End Message ---