emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#36301: closed (Package-Requires should support mul


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#36301: closed (Package-Requires should support multiple lines)
Date: Fri, 16 Aug 2019 04:04:01 +0000

Your message dated Fri, 16 Aug 2019 00:03:40 -0400
with message-id <address@hidden>
and subject line Re: bug#36301: Package-Requires should support multiple lines
has caused the debbugs.gnu.org bug report #36301,
regarding Package-Requires should support multiple lines
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36301: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36301
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Package-Requires should support multiple lines Date: Wed, 19 Jun 2019 21:55:27 -0400
Hi,

The Package-Requires line in my GNU ELPA package, Excorporate, is much
longer than 80 characters and I would like to wrap it.  It would be nice
if package.el allowed Package-Requires to span multiple lines (see
patch).  It's probably too late to change this but I thought I'd file a
bug report anyway.

Thomas

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 46f7c91272..5c9b12732d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1016,7 +1016,8 @@ package-buffer-info
     (narrow-to-region start (point))
     (require 'lisp-mnt)
     ;; Use some headers we've invented to drive the process.
-    (let* ((requires-str (lm-header "package-requires"))
+    (let* ((requires-str
+            (mapconcat 'identity (lm-header-multiline "package-requires") " "))
            ;; Prefer Package-Version; if defined, the package author
            ;; probably wants us to use it.  Otherwise try Version.
            (pkg-version



--- End Message ---
--- Begin Message --- Subject: Re: bug#36301: Package-Requires should support multiple lines Date: Fri, 16 Aug 2019 00:03:40 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Noam Postavsky <address@hidden> writes:

> severity 36301 wishlist
> quit
>
> Thomas Fitzsimmons <address@hidden> writes:
>
>> The Package-Requires line in my GNU ELPA package, Excorporate, is much
>> longer than 80 characters and I would like to wrap it.  It would be nice
>> if package.el allowed Package-Requires to span multiple lines (see
>> patch).  It's probably too late to change this but I thought I'd file a
>> bug report anyway.
>
> I don't see a problem with changing it now, except that you won't be
> able to actually wrap the Package-Requires line in Excorporate until
> that package requires Emacs 27 or later.

OK, I pushed the change to master.

Thanks,
Thomas


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]