[debbugs-tracker] bug#36712: closed (27.0.50; nnimap unconditionally setting marks in a loop)

[GNU bug Tracking System]

Your message dated Thu, 25 Jul 2019 12:26:34 -0700
with message-id <address@hidden>
and subject line Re: bug#36712: Acknowledgement (27.0.50; nnimap 
unconditionally setting marks in a loop)
has caused the debbugs.gnu.org bug report #36712,
regarding 27.0.50; nnimap unconditionally setting marks in a loop
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36712: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36712
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 27.0.50; nnimap unconditionally setting marks in a loop Date: Wed, 17 Jul 2019 18:09:45 -0700

I started doing some very basic profiling of Gnus, and noticed that
getting new mail was resulting in a couple thousand calls to
`gnus-info-set-entry', as well as some of the range manipulation
functions.

It looks like updating IMAP group marks using qresync would loop over
all possible flag/mark pairs and unconditionally set everything, even
when there was nothing to set. With fewer than 100 IMAP groups in total,
that was a couple thousand extra function calls. Most of them with nil
arguments, but still.

I'm not super familiar with the code in question, but the attached diff
looks like it will pull the qresync behavior in line with the
non-qresync behavior, so I'm hoping it's correct. It cuts way down on
function calls, anyway!




In GNU Emacs 27.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.10)
 of 2019-07-15 built on slip
Repository revision: c687f25ee24bd29d623a23819eef930937252b25
Windowing system distributor 'The X.Org Foundation', version 11.0.12005000
System Description:     Arch Linux

nnimap-dont-add-marks.diff
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#36712: Acknowledgement (27.0.50; nnimap unconditionally setting marks in a loop)
>
>
>
>
> Date: 
>
> Thu, 25 Jul 2019 12:26:34 -0700
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
>
>
>
>
> On 07/25/19 19:03 PM, Lars Ingebrigtsen wrote:
> > Eric Abrahamsen <address@hidden> writes:
> >
> >> Well, I'm fairly sure now this is the right thing to do. I'll leave this
> >> open for a few more days, then push a fix.
> >
> > I think your patch looks correct...
>
> Okay, I went ahead and pushed it.
>
> Thanks!
>
>
> --- End Message ---