[debbugs-tracker] bug#35470: closed ([PATCH] services: slim: Honor the value of slim from slim-configuration.)

[GNU bug Tracking System]

Your message dated Mon, 29 Apr 2019 09:32:26 +0200
with message-id <address@hidden>
and subject line Re: [bug#35470] [PATCH] services: slim: Honor the value of 
slim from slim-configuration.
has caused the debbugs.gnu.org bug report #35470,
regarding [PATCH] services: slim: Honor the value of slim from 
slim-configuration.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35470: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35470
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: slim: Honor the value of slim from slim-configuration.
>
>
>
>
> Date: 
>
> Sun, 28 Apr 2019 14:14:21 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hi Guix,
>
> I have noticed that setting the slim field in slim-configuration does
> not have any effect.  This patch should fix that.
>
> Regards,
>
> Diego
>
> >From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <address@hidden>
> Date: Sat, 27 Apr 2019 19:45:47 +0200
> Subject: [PATCH] services: slim: Honor the value of slim from
>  slim-configuration.
>
> Previously setting the slim field in slim-configuration would have no effect.
>
> * gnu/services/xorg.scm (slim-shepherd-service): Remove unused let binding for
>   slim.  Use (slim-configuration-slim config) instead of the default slim.
> ---
>  gnu/services/xorg.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
> index d4e73c13b4..44dcec4ec9 100644
> --- a/gnu/services/xorg.scm
> +++ b/gnu/services/xorg.scm
> @@ -502,7 +502,6 @@ desktop session from the system or user profile will be 
> used."
>    (define slim.cfg
>      (let ((xinitrc (xinitrc #:fallback-session
>                              (slim-configuration-auto-login-session config)))
> -          (slim    (slim-configuration-slim config))
>            (xauth   (slim-configuration-xauth config))
>            (startx  (xorg-start-command (slim-configuration-xorg config)))
>            (shepherd   (slim-configuration-shepherd config))
> @@ -547,7 +546,9 @@ reboot_cmd " shepherd "/sbin/reboot\n"
>                (false-if-exception (delete-file "/var/run/slim.lock"))
>  
>                (fork+exec-command
> -               (list (string-append #$slim "/bin/slim") "-nodaemon")
> +               (list (string-append #$(slim-configuration-slim config)
> +                                    "/bin/slim")
> +                     "-nodaemon")
>                 #:environment-variables
>                 (list (string-append "SLIM_CFGFILE=" #$slim.cfg)
>                       #$@(if theme
> -- 
> 2.21.0
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35470] [PATCH] services: slim: Honor the value of slim from slim-configuration.
>
>
>
>
> Date: 
>
> Mon, 29 Apr 2019 09:32:26 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Diego Nicola Barbato <address@hidden> skribis:
>
> >>From 85c4a2764baba987d1ddd4dd67f7d33f9e49e9ea Mon Sep 17 00:00:00 2001
> > From: Diego Nicola Barbato <address@hidden>
> > Date: Sat, 27 Apr 2019 19:45:47 +0200
> > Subject: [PATCH] services: slim: Honor the value of slim from
> >  slim-configuration.
> >
> > Previously setting the slim field in slim-configuration would have no effect.
> >
> > * gnu/services/xorg.scm (slim-shepherd-service): Remove unused let binding for
> >   slim.  Use (slim-configuration-slim config) instead of the default slim.
>
> Good catch.  Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---