[debbugs-tracker] bug#35277: closed (26.1.90; Non-assigned variable used in condition)

[GNU bug Tracking System]

Your message dated Mon, 15 Apr 2019 20:58:04 -0700
with message-id <address@hidden>
and subject line 26.1.90; Non-assigned variable used in condition
has caused the debbugs.gnu.org bug report #35277,
regarding 26.1.90; Non-assigned variable used in condition
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35277: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35277
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.1.90; Non-assigned variable used in condition
>
>
>
>
> Date: 
>
> Sun, 14 Apr 2019 19:21:46 +0200
>
>
>
>
> ../../emacs/src/widget.c: In function ‘EmacsFrameQueryGeometry’:
> ../../emacs/src/widget.c:457:29: warning: ‘ok_height’ may be used uninitialized 
> in this function [-Wmaybe-uninitialized]
>        if ((mask & CWHeight) && (ok_height != request->height))
>            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../emacs/src/widget.c:455:18: warning: ‘ok_width’ may be used uninitialized 
> in this function [-Wmaybe-uninitialized]
>     result->width = ok_width;
>     ~~~~~~~~~~~~~~^~~~~~~~~~
>
> I checked that the warnings are legit. With
>
> (setq frame-resize-pixelwise t)
>
> ok_width is used in the `if'. Not ok_height, at least on my experiments,
> but removing the warning would be nice.
>
> Note that the warning for `ok_width' points to the assignment, but it is
> used right before on the `if'.
>
>
> In GNU Emacs 26.1.90 (build 2, x86_64-pc-linux-gnu, X toolkit)
>  of 2019-03-16 built on sky
> Repository revision: df7ed10e4f15d3ea8b4426f7721bafe60bf8deeb
> Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
> System Description:     Debian GNU/Linux buster/sid
>
> Recent messages:
> Saving file /home/oscar/elisp/emacs.el...
> Wrote /home/oscar/elisp/emacs.el
> Auto-saving...done
> Saving file /home/oscar/dev/emacs/emacs/src/widget.c...
> Wrote /home/oscar/dev/emacs/emacs/src/widget.c
> Saving file /home/oscar/dev/emacs/emacs/src/widget.c...
> Wrote /home/oscar/dev/emacs/emacs/src/widget.c
> [C-t] show common commands, [?] describe events, [C-h i] show manual
> Saving file /home/oscar/elisp/emacs.el...
> Wrote /home/oscar/elisp/emacs.el
> Quit
> Configured using:
>  'configure --without-toolkit-scroll-bars --with-x-toolkit=lucid
>  --with-modules'
>
> Configured features:
> XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GSETTINGS GLIB NOTIFY LIBSELINUX
> GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB LUCID X11 XDBE XIM MODULES
> THREADS
>
> Important settings:
>   value of $LANG: C
>   locale-coding-system: nil
>
>
>
> --- End Message ---

--- Begin Message --- Subject: 26.1.90; Non-assigned variable used in condition Date: Mon, 15 Apr 2019 20:58:04 -0700 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

Thanks for reporting that. I installed the attached patch into Emacs master.

0001-Fix-uninit-var-in-widget.c.patch
Description: Text Data

--- End Message ---