--- Begin Message ---
|
Subject: |
[PATCH] Resurrect pplacer. |
|
Date: |
Tue, 09 Apr 2019 15:00:02 +0200 |
|
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Guix,
this patch series adds pplacer, which had been removed due to its
dependency on the vulnerable OCaml 4.01.
--
Ricardo
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#35207] [PATCH] Resurrect pplacer. |
|
Date: |
Thu, 11 Apr 2019 17:23:21 +0200 |
|
User-agent: |
mu4e 1.0; emacs 26.1 |
Ricardo Wurmus <address@hidden> writes:
> Julien Lepiller <address@hidden> writes:
>
>> Le 11 avril 2019 14:55:44 GMT+02:00, Ricardo Wurmus <address@hidden> a écrit
>> :
>>>
>>>Ricardo Wurmus <address@hidden> writes:
>>>
>>>> Julien Lepiller <address@hidden> writes:
>>>>
>>>>> What's the most recent version of ocaml pplacer can use?
>>>>
>>>> It’s actually 4.01. I don’t know how much effort it’s going to be to
>>>> make it work with the latest version.
>>>
>>>I gave patching pplacer a try, but in more recent versions of OCaml
>>>strings are byte streams, so it’s quite a bit of work to figure out
>>>where exactly to convert strings to byte streams and back again.
>>>
>>>I’ll keep working on this for a while, but for now I’d like to get
>>>pplacer resurrected with 4.02 first.
>>>
>>>--
>>>Ricardo
>>
>> Ok, I guess it's acceptable. I'll fully review your patches later today.
>
> Thanks for the offer, but it won’t be necessary after all. I figured
> out how to make it work with the latest OCaml. I had to also patch
> ocaml-mcl, but that seems okay.
>
> New patches coming in a few minutes!
I pushed the new patches to the “master” branch with commit 12327d7447.
--
Ricardo
--- End Message ---