[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#34532: closed (Unhandled errors in vc)

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#34532: closed (Unhandled errors in vc)
Date: Tue, 19 Mar 2019 21:54:01 +0000

Your message dated Tue, 19 Mar 2019 23:52:47 +0200
with message-id <address@hidden>
and subject line Re: bug#34532: Unhandled errors in vc
has caused the debbugs.gnu.org bug report #34532,
regarding Unhandled errors in vc
to be marked as done.

(If you believe you have received this mail in error, please contact

34532: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34532
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Unhandled errors in vc Date: Mon, 18 Feb 2019 23:37:44 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
After ‘C-x v g’ (vc-annotate) typing ‘a’ (vc-annotate-revision-previous-to-line)
in the *Annotate* buffer on the earliest (initial) revision fails with:

  Debugger entered--Lisp error: (error "Invalid argument to 
    signal(error ("Invalid argument to vc-annotate-warp-revision"))
    error("Invalid argument to vc-annotate-warp-revision")
    vc-annotate-warp-revision(nil "...")

This patch provides a nicer message:

diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el
index 86fc8686c3..84838135fc 100644
--- a/lisp/vc/vc-annotate.el
+++ b/lisp/vc/vc-annotate.el
@@ -541,7 +541,9 @@ vc-annotate-revision-previous-to-line
        (setq prev-rev
              (vc-call-backend vc-annotate-backend 'previous-revision
                                fname rev))
-       (vc-annotate-warp-revision prev-rev fname)))))
+       (if (not prev-rev)
+            (message "No previous revisions")
+          (vc-annotate-warp-revision prev-rev fname))))))
 (defvar log-view-vc-backend)
 (defvar log-view-vc-fileset)

--- End Message ---
--- Begin Message --- Subject: Re: bug#34532: Unhandled errors in vc Date: Tue, 19 Mar 2019 23:52:47 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
> This is now fixed.
> Another problem is that ‘vc-root-version-diff’ can't be used when
> fileset is not available.  But this command doesn't use fileset,
> it uses the root directory, so this patch adds an optional
> arg ‘fileset’ to ‘vc-diff-build-argument-list-internal’,
> so ‘vc-root-version-diff’ can provide its own fake fileset
> with the root directory:

Fixed as well.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]