emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#34626: closed (pack: Construct inferior package na


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#34626: closed (pack: Construct inferior package names correctly.)
Date: Fri, 15 Mar 2019 22:27:01 +0000

Your message dated Fri, 15 Mar 2019 23:26:13 +0100
with message-id <address@hidden>
and subject line Re: [bug#34626] pack: Construct inferior package names 
correctly.
has caused the debbugs.gnu.org bug report #34626,
regarding pack: Construct inferior package names correctly.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34626: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34626
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: pack: Construct inferior package names correctly. Date: Fri, 22 Feb 2019 23:11:50 -0500 User-agent: Cyrus-JMAP/3.1.5-895-g0d23ba6-fmstable-20190213v1
Hello everyone,

This patch fixes a bug where inferior packages' names were not being
constructed correctly when calling `guix pack --relocatable`.

Cheers,

Shyam

Attachment: 0001-pack-Construct-inferior-package-names-correctly.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: [bug#34626] pack: Construct inferior package names correctly. Date: Fri, 15 Mar 2019 23:26:13 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Hello,

Shyam <address@hidden> skribis:

> This patch fixes a bug where inferior packages' names were not being
> constructed correctly when calling `guix pack --relocatable`.

Good catch!

>>From dd2171ce0d074cb6003afdaec353df572ed784a8 Mon Sep 17 00:00:00 2001
> From: "P.C. Shyamshankar" <address@hidden>
> Date: Fri, 22 Feb 2019 22:38:47 -0500
> Subject: [PATCH] pack: Construct inferior package names correctly.
>
> * guix/scripts/pack.scm: 'wrapped-package' now correctly constructs full
>   names of inferior packages, allowing relocatable packs.

Applied with the minor change below.

Thank you, and sorry for the delay!

Ludo’.

diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index e40c2085f7..17a166d9d7 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -28,7 +28,7 @@
   #:use-module (guix store)
   #:use-module ((guix status) #:select (with-status-verbosity))
   #:use-module (guix grafts)
-  #:use-module (guix inferior)
+  #:autoload   (guix inferior) (inferior-package?)
   #:use-module (guix monads)
   #:use-module (guix modules)
   #:use-module (guix packages)
@@ -593,7 +593,8 @@ please email '~a'~%")
                         ((inferior-package? package)
                          (string-append (inferior-package-name package)
                                         "-"
-                                        (inferior-package-version package))))
+                                        (inferior-package-version package)))
+                        (else "wrapper"))
                   "R")
                  build))
 

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]