[debbugs-tracker] bug#34240: closed ([PATCH 0/5] Gnome printing improvements)

[GNU bug Tracking System]

Your message dated Wed, 13 Feb 2019 08:21:04 +0000
with message-id <address@hidden>
and subject line Re: [bug#34240] [PATCH 4/5] gnu: Add system-config-printer.
has caused the debbugs.gnu.org bug report #34240,
regarding [PATCH 0/5] Gnome printing improvements
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34240: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34240
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH 0/5] Gnome printing improvements Date: Tue, 29 Jan 2019 11:37:24 +0000 User-agent: mu4e 1.0; emacs 26.1

These patches work towards allowing easy configuration of printers
within Gnome (and probably other desktop environments).

Previously, the gnome-control-center printer configuration would simply
not work, as I believe it depends on cups-pk-helper and
system-config-printer. With these two things present, it works better,
but I encounter authentication issues.


Christopher Baines (5):
  gnu: Add cups-pk-helper.
  services: Add cups-pk-helper.
  gnu: Add python-pycups.
  gnu: Add system-config-printer.
  gnu: gnome: Include system-config-printer.

 gnu/packages/cups.scm    | 52 ++++++++++++++++++++++++
 gnu/packages/gnome.scm   | 88 ++++++++++++++++++++++++++++++++++++++++
 gnu/services/desktop.scm | 17 ++++++++
 3 files changed, 157 insertions(+)

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#34240] [PATCH 4/5] gnu: Add system-config-printer. Date: Wed, 13 Feb 2019 08:21:04 +0000 User-agent: mu4e 1.0; emacs 26.1

Ricardo Wurmus <address@hidden> writes:

> Christopher Baines <address@hidden> writes:
>
>> * gnu/packages/gnome.scm (system-config-printer): New variable.
> […]
>> +    (arguments
>> +     `(#:imported-modules ((guix build python-build-system)
>> +                           ,@%glib-or-gtk-build-system-modules)
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'patch-Makefile.am
>> +           (lambda _
>> +             ;; The Makefile generates some scripts, so set a valid shebang
>> +             (substitute* "Makefile.am"
>> +               (("/bin/bash") (which "bash")))
>> +             #t))
> […]
>> +         (add-before 'configure 'bootstrap
>> +           (lambda _
>> +             ;; Run ./bootstrap as otherwise the build fails with
>> +             ;; automake-1.15: command not found
>> +             (invoke "./bootstrap")
>> +             #t))
>
> The build system already provides a “bootstrap” phase, so maybe it would
> be better to delete “configure” in “patch-Makefile.am” to activate the
> bootstrap phase.
>
> Otherwise looks good to me.  Thanks!

Great, I've made that change to the system-config-printer phases and
pushed these patches now.

Thanks,

Chris

signature.asc
Description: PGP signature

--- End Message ---