|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#33684: closed (DocView bombs out upon password protected PDFs) |
Date: | Mon, 04 Feb 2019 15:50:02 +0000 |
Your message dated Mon, 04 Feb 2019 16:49:25 +0100 with message-id <address@hidden> and subject line Re: bug#33684: DocView bombs out upon password protected PDFs has caused the debbugs.gnu.org bug report #33684, regarding DocView bombs out upon password protected PDFs to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 33684: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33684 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: DocView bombs out upon password protected PDFs Date: Sun, 09 Dec 2018 18:52:50 +0800 When trying to view a password protected PDF: DocView: process pdf/ps->png changed status to exited abnormally with code 1. Maybe it should ask for the password. emacs-version "25.2.2"
--- End Message ---
--- Begin Message ---Subject: Re: bug#33684: DocView bombs out upon password protected PDFs Date: Mon, 04 Feb 2019 16:49:25 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Eli Zaretskii <address@hidden> writes: >> > Hi Tassilo, thanks for your feedback. I've created a new patch with >> > the commit message, and also added an entry to NEWS. I'm attaching >> it >> > here. >> >> Looks perfect. Small nitpick: we use * for bullet points instead of >> - in the commit message, but I can amend that. I can't push it from >> work, so I'll do it this evening. > > When you do, please be sure to amend the log message to mention the > bug number. > > Also, the doc strings of 2 of the new functions need to be reformatted > to have the first line be a complete sentence. (Just move the second > sentence to the next line, I'd say.) Pushed with the aforementioned changes. Thanks again, Federico! Tassilo
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |