[debbugs-tracker] bug#34258: closed ([PATCH 1/2] gnu: Add python-discid.)

[GNU bug Tracking System]

Your message dated Thu, 31 Jan 2019 22:06:47 +0100
with message-id <address@hidden>
and subject line Re: [bug#34258] [PATCH 1/2] gnu: Add python-discid.
has caused the debbugs.gnu.org bug report #34258,
regarding [PATCH 1/2] gnu: Add python-discid.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34258: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34258
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH 1/2] gnu: Add python-discid. Date: Wed, 30 Jan 2019 16:36:44 +0100 User-agent: mu4e 1.0; emacs 26.1

* gnu/packages/music.scm (python-discid): New variable.
---
 gnu/packages/music.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 4943b901e..5a07ad4ae 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -19,6 +19,7 @@
 ;;; Copyright © 2018 Pierre Neidhardt <address@hidden>
 ;;; Copyright © 2018 Ludovic Courtès <address@hidden>
 ;;; Copyright © 2018 Björn Höfling <address@hidden>
+;;; Copyright © 2019 Gabriel Hondet <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4076,6 +4077,41 @@ it provides a submission URL for adding the disc ID to 
the database and gathers
 ISRCs and the MCN (=UPC/EAN) from disc.")
     (license license:lgpl2.1+)))
 
+(define-public python-discid
+  (package
+    (name "python-discid")
+    (version "1.1.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "discid" version))
+        (sha256
+          (base32
+            "1fgp67nhqlbvhhwrcxq5avil7alpzw4s4579hlyvxzbphdnbz8vq"))))
+    (build-system python-build-system)
+    (inputs
+     `(("libdiscid" ,libdiscid)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-libdiscid
+           ;; Set path of libdiscid
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((discid (assoc-ref inputs "libdiscid")))
+               (substitute* "discid/libdiscid.py"
+                 (("lib_name = (.*)$" all name)
+                  (string-append "lib_name = \"" discid
+                                 "/lib/libdiscid.so.0\"\n")))))))))
+    (home-page "https://python-discid.readthedocs.io/";)
+    (synopsis "Python binding of Libdiscid")
+    (description "This package provides a python binding of Libdiscid by
+Musicbrainz.  The main purpose is the calculation of an identifier for audio
+discs @url{http://musicbrainz.org/doc/Disc%20ID, Disc ID} to use for the
address@hidden://musicbrainz.org/, MusicBrainz database.  Additionally the disc
address@hidden, Media Catalog Number} and track @acronym{ISRC, Internation
+Standard Recording Code} can be extracted.}")
+    (license license:lgpl3+)))
+
 (define-public libmusicbrainz
   (package
     (name "libmusicbrainz")
-- 
2.20.1

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#34258] [PATCH 1/2] gnu: Add python-discid. Date: Thu, 31 Jan 2019 22:06:47 +0100 User-agent: Notmuch/0.28 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu)

Gabriel Hondet <address@hidden> writes:

> * gnu/packages/music.scm (python-discid): New variable.

[...]

> * gnu/packages/music.scm (python-isrcsubmit): New variable.

I fixed the indentation, made some editorialization of the descriptions
(note that the Guile TexInfo implementation does not have @acronym yet)
and pushed both patches as <84243592fe..07c82daad4>.

Thank you!

signature.asc
Description: PGP signature

--- End Message ---