[debbugs-tracker] bug#33846: closed ([PATCH] gnu: ruby: Remove versions 1.8, 2.1 and 2.2.)

[GNU bug Tracking System]

Your message dated Wed, 02 Jan 2019 16:00:44 +0800
with message-id <address@hidden>
and subject line Re: [bug#33846] [PATCH] gnu: ruby: Remove versions 1.8, 2.1 
and 2.2.
has caused the debbugs.gnu.org bug report #33846,
regarding [PATCH] gnu: ruby: Remove versions 1.8, 2.1 and 2.2.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33846: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33846
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] gnu: ruby: Remove versions 1.8, 2.1 and 2.2. Date: Sun, 23 Dec 2018 17:39:09 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello,

This patch removes all ruby versions which have reached EOL since they
no longer receive official security updates.

However, please do complain if you need to use one of these
versions. IMO, it is better to have a central place for them to receive
(unofficial) security updates (e.g. Debian will support ruby 2.1 until
2020), than to roll your own security updates (which is error-prone and
duplicate effort).

From 2063870b76c6197e34764750f7ca6be1f41d8871 Mon Sep 17 00:00:00 2001
From: Alex Vong <address@hidden>
Date: Sat, 22 Dec 2018 07:30:41 +0800
Subject: [PATCH] gnu: ruby: Remove versions 1.8, 2.1 and 2.2.

Remove ruby versions which have reached EOL.

See <https://lists.gnu.org/archive/html/guix-devel/2018-11/msg00421.html>.

* gnu/packages/ruby.scm (ruby-1.8, ruby-2.1, ruby-2.2): Remove variables.
---
 gnu/packages/ruby.scm | 68 -------------------------------------------
 1 file changed, 68 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 52832eeeb..2063579e0 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -126,74 +126,6 @@ a focus on simplicity and productivity.")
                    (delete-file-recursively "ext/fiddle/libffi-3.2.1")
                    #t))))))
 
-(define-public ruby-2.2
-  (package (inherit ruby)
-    (version "2.2.10")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "http://cache.ruby-lang.org/pub/ruby/";
-                           (version-major+minor version)
-                           "/ruby-" version ".tar.xz"))
-       (sha256
-        (base32
-         "0l5nk9mc0q4769d2i9d9y1izk0pk0lms2bl8s3lclv36wsvvqxxz"))))))
-
-(define-public ruby-2.1
-  (package (inherit ruby)
-    (version "2.1.10")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "http://cache.ruby-lang.org/pub/ruby/";
-                           (version-major+minor version)
-                           "/ruby-" version ".tar.bz2"))
-       (sha256
-        (base32
-         "1wglbd599mlwxfcb2xgqcxi2shr363pjn5dpbv11m04si9bpaim7"))))
-    (arguments
-     `(#:test-target "test"
-       #:parallel-tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'configure 'replace-bin-sh
-           (lambda _
-             (substitute* '("Makefile.in"
-                            "ext/pty/pty.c"
-                            "io.c"
-                            "lib/mkmf.rb"
-                            "process.c")
-               (("/bin/sh") (which "sh")))
-             #t)))))))
-
-(define-public ruby-1.8
-  (package (inherit ruby)
-    (version "1.8.7-p374")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "http://cache.ruby-lang.org/pub/ruby/";
-                           (version-major+minor version)
-                           "/ruby-" version ".tar.bz2"))
-       (sha256
-        (base32
-         "1qq7khilwkayrhwmzlxk83scrmiqfi7lgsn4c63znyvz2c1lgqxl"))))
-    (native-search-paths '())
-    (arguments
-     `(#:test-target "test"
-       #:parallel-tests? #f
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'configure 'replace-bin-sh
-           (lambda _
-             (substitute* '("Makefile.in"
-                            "ext/pty/pty.c"
-                            "io.c"
-                            "lib/mkmf.rb"
-                            "process.c")
-               (("/bin/sh") (which "sh")))
-             #t)))))))
-
 (define-public ruby-highline
   (package
     (name "ruby-highline")
-- 
2.19.2

Cheers,
Alex

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#33846] [PATCH] gnu: ruby: Remove versions 1.8, 2.1 and 2.2. Date: Wed, 02 Jan 2019 16:00:44 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

I add the missing copyright notice
and push as 8ef06557473e4394c2d0d9d54b45c43456419b66

Alex Vong <address@hidden> writes:

> Pjotr Prins <address@hidden> writes:
>
>> On Sun, Dec 23, 2018 at 05:39:09PM +0800, Alex Vong wrote:
>>> Hello,
>>> 
>>> This patch removes all ruby versions which have reached EOL since they
>>> no longer receive official security updates.
>>> 
>>> However, please do complain if you need to use one of these
>>> versions. IMO, it is better to have a central place for them to receive
>>> (unofficial) security updates (e.g. Debian will support ruby 2.1 until
>>> 2020), than to roll your own security updates (which is error-prone and
>>> duplicate effort).
>>> 
>>
>> Thanks Alex,
>>
>> No objection. Note that we now have the channel mechanism to suport
>> older versions of software we don't need to maintain older versions
>> inside GNU Guix if there are no down stream dependencies.
>>
> OK. I have found that there is a guix-chromium channel. So I think I
> understand what you mean now.
>
>> Pj.
>
> Thanks,
> Alex

signature.asc
Description: PGP signature

--- End Message ---