[debbugs-tracker] bug#33259: closed ([PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more tests)

[GNU bug Tracking System]

Your message dated Tue, 06 Nov 2018 23:23:51 +0100
with message-id <address@hidden>
and subject line Re: [bug#33259] [PATCH 4/8] pack: Docker backend now honors 
'--localstatedir'.
has caused the debbugs.gnu.org bug report #33259,
regarding [PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more 
tests
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33259: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33259
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more tests
>
>
>
>
> Date: 
>
> Sun,  4 Nov 2018 23:01:30 +0100
>
>
>
>
> Hello Guix!
>
> These patches ensure ‘--localstatedir’ is properly handled by the
> Docker and Squashfs backends of ‘guix pack’ (until now they ignored
> this option.)
>
> They also add ‘guix pack’ tests, which were severely lacking until now,
> including a ‘guix pack -R’ test using the user’s store.  While doing
> that, I also fixed a bug whereby ‘guix pack’ tarballs would contain
> writable directories (whereas normally every file in the store is
> read-only.)
>
> Feedback welcome!
>
> Ludo’.
>
> Ludovic Courtès (8):
>   pack: Move store database creation to a separate derivation.
>   pack: Import (guix store database) only when '--localstatedir' is
>     passed.
>   install: Add 'install-database-and-gc-roots'.
>   pack: Docker backend now honors '--localstatedir'.
>   pack: Squashfs backend now honors '--localstatedir'.
>   pack: Add test for 'self-contained-tarball' with localstatedir.
>   store-copy: Canonicalize the mtime and permissions of the store copy.
>   pack: Add test for '--relocatable'.
>
>  Makefile.am                    |   1 +
>  gnu/build/install.scm          |  77 ++++---
>  gnu/build/vm.scm               |  19 +-
>  guix/build/store-copy.scm      |  28 +++
>  guix/docker.scm                |  16 +-
>  guix/scripts/pack.scm          | 379 +++++++++++++++++++--------------
>  tests/guix-pack-relocatable.sh |  61 ++++++
>  tests/guix-pack.sh             |  28 +--
>  tests/pack.scm                 | 156 ++++++++++++--
>  9 files changed, 525 insertions(+), 240 deletions(-)
>  create mode 100644 tests/guix-pack-relocatable.sh
>
> -- 
> 2.19.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#33259] [PATCH 4/8] pack: Docker backend now honors '--localstatedir'.
>
>
>
>
> Date: 
>
> Tue, 06 Nov 2018 23:23:51 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> address@hidden (Ludovic Courtès) skribis:
>
> > Danny Milosavljevic <address@hidden> skribis:
> >
> >>> diff --git a/tests/pack.scm b/tests/pack.scm
> >>> index 6bd18bdee2..e8d4f9f18d 100644
> >>> --- a/tests/pack.scm
> >>> +++ b/tests/pack.scm
> >>> @@ -22,6 +22,7 @@
> >>>    #:use-module (guix store)
> >>>    #:use-module (guix derivations)
> >>>    #:use-module (guix profiles)
> >>
> >>> +  #:use-module (guix packages)                    ;XXX: debugging
> >>
> >> Is this still needed?
> >
> > Oops, I don’t think so.  I’ll fix it before pushing.
>
> Well it was actually needed so I just removed the comment.
>
> Pushed, thanks for reviewing!
>
> Ludo’.
>
>
> --- End Message ---