--- Begin Message ---
Subject: |
26; [REGRESSION] `dired-query' key help (`help-form-show') |
Date: |
Mon, 3 Sep 2018 18:04:23 -0700 (PDT) |
This is a regression introduced in Emacs 26.1 - no problem before that.
emacs -Q
1. In a Dired buffer (directory `toto', say) create a subdir `foo', mark
two files in `toto', and then use `C' to copy those two files from `toto' to
`foo'.
2. Use `M' with `a-w' to make the copies in `foo' read-only.
3. Turn on `debug-on-error'.
4. In `toto', use `C' again to try to copy the same marked files.
Let's say that the first file to copy is `a'. You see this prompt:
Overwrite `/the/path/to/toto/foo/a'? [Type yn!q or C-h]
Use `C-h' to try to see the key help. This happens:
`help-form-show' raises an error: (void-variable to).
It seems like the "to" in the prompt is being evaluated as a variable.
Perhaps there is a missing quote somewhere.
You can no longer use any keys at this point, including mouse actions.
(Except you can use `q' to quit the debugger.)
Because I cannot use keys at that point I cannot select the text in the
debugger to show it. Instead, see attached screenshot (file names redacted).
In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
`configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
throw-emacs-bug-dired-query.png
Description: PNG image
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#32630: 26; [REGRESSION] `dired-query' key help (`help-form-show') |
Date: |
Sat, 20 Oct 2018 18:58:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> > > index 21ee50ce5c..dc34037be9 100644
> > > --- a/lisp/dired-aux.el
> > > +++ b/lisp/dired-aux.el
> > > @@ -1731,7 +1731,7 @@ dired-create-files
> > > (let* ((overwrite (file-exists-p to))
> > > (dired-overwrite-confirmed ; for dired-handle-overwrite
> > > (and overwrite
> > > - (let ((help-form '(format-message "\
> > > + (let ((help-form (format-message "\
> > > Type SPC or `y' to overwrite file `%s',
> > > DEL or `n' to skip to next,
> > > ESC or `q' to not overwrite any of the remaining files,
> >
> > To which branch should I install this fix?
>
> To emacs-26, please.
Thanks. Committed as 1531bca "Fix help-form binding in
dired-create-files" to emacs-26.
Michael.
--- End Message ---