emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#31237: closed ([PATCH] gnu: Add runc.)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#31237: closed ([PATCH] gnu: Add runc.)
Date: Thu, 26 Apr 2018 01:41:01 +0000

Your message dated Thu, 26 Apr 2018 09:39:58 +0800
with message-id <address@hidden>
and subject line Re: [bug#31237] [PATCH] gnu: Add runc.
has caused the debbugs.gnu.org bug report #31237,
regarding [PATCH] gnu: Add runc.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31237: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31237
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] gnu: Add runc. Date: Sun, 22 Apr 2018 20:58:44 +0800
* gnu/packages/virtualization.scm (runc): New variable.
---
 gnu/packages/virtualization.scm | 54 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 53 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 55ace5a56..e6d52c870 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2017 Rutger Helling <address@hidden>
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <address@hidden>
 ;;; Copyright © 2018 Danny Milosavljevic <address@hidden>
+;;; Copyright © 2018 Sou Bunnbu <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -41,6 +42,7 @@
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages libusb)
@@ -65,7 +67,8 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
   #:use-module (guix download)
-  #:use-module ((guix licenses) #:select (gpl2 gpl2+ gpl3+ lgpl2.1 lgpl2.1+))
+  #:use-module ((guix licenses) #:select (gpl2 gpl2+ gpl3+ lgpl2.1 lgpl2.1+
+                                               asl2.0))
   #:use-module (guix packages)
   #:use-module (guix utils)
   #:use-module (srfi srfi-1))
@@ -772,3 +775,52 @@ monitor/GPU.")
    ;; This package requires SSE instructions.
    (supported-systems '("i686-linux" "x86_64-linux"))
    (license gpl2+)))
+
+(define-public runc
+  (package
+    (name "runc")
+    (version "1.0.0-rc5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/opencontainers/runc/releases/";
+                    "download/v" version "/runc.tar.xz"))
+              (sha256
+               (base32
+                "081avdzwnqpk368wbaihlzsypaxpj42d7699h7jgp0fks14x4103"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f                      ; FIXME: 20/139 tests fail.
+       #:test-target "localunittest"
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)            ; no 'configure' script
+         (replace 'build
+           (lambda _
+             (let* ((gopath (string-append (getenv "TMPDIR") "/go"))
+                    (srcdir (string-append
+                             gopath "/src/github.com/opencontainers/runc")))
+               (setenv "GOPATH" gopath)
+               (mkdir-p (dirname srcdir))
+               (copy-recursively (getcwd) srcdir)
+               (chdir srcdir)
+               ;; XXX: requires 'go-md2man'.
+               ;; (invoke "make man")
+               (invoke "make"))))
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+              (invoke "make" "install" "install-bash"
+                      (string-append "PREFIX=" out))))))))
+    (native-inputs
+     `(("go" ,go)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libseccomp" ,libseccomp)))
+    (synopsis "Open container initiative runtime")
+    (home-page "https://www.opencontainers.org/";)
+    (description
+     "@command{runc} is a command line client for running applications
+packaged according to the Open Container Initiative (OCI) format and is a
+compliant implementation of the Open Container Initiative specification.")
+    (license asl2.0)))
-- 
2.13.3




--- End Message ---
--- Begin Message --- Subject: Re: [bug#31237] [PATCH] gnu: Add runc. Date: Thu, 26 Apr 2018 09:39:58 +0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
address@hidden (Ludovic Courtès) writes:

> Hello,
>
> address@hidden (宋文武) skribis:
>
>> No I haven't, some fails are:
>>
>> --- FAIL: TestFactoryNewTmpfs (0.00s)
>>      factory_linux_test.go:87: operation not permitted
>>
>> FAIL github.com/opencontainers/runc/libcontainer     0.047s
>> ?    github.com/opencontainers/runc/libcontainer/apparmor    [no test files]
>>
>> --- FAIL: TestInvalidCgroupPath (0.00s)
>>      apply_raw_test.go:16: couldn't get cgroup root: mountpoint for
>> cgroup not found
>>      apply_raw_test.go:25: couldn't get cgroup data: mountpoint for
>> cgroup not found
>> panic: runtime error: invalid memory address or nil pointer dereference 
>> [recovered]
>>
>> --- FAIL: TestValidateRootlessMountUid (0.00s)
>>      rootless_test.go:96: Expected error to not occur when uid= not
>> set in mount options: rootfs (/var) does not exist
>>      rootless_test.go:106: Expected error to not occur when setting
>> uid=0 in mount options: rootfs (/var) does not exist
>>      rootless_test.go:112: Expected error to not occur when setting
>> uid=2 in mount options and UidMapping[0].size is 10
>>
>> --- FAIL: TestValidateValidSysctl (0.00s)
>>      validator_test.go:229: Expected error to not occur with
>> {net.ctl=ctl} but got: "rootfs (/var) does not exist"
>>      validator_test.go:229: Expected error to not occur with
>> {kernel.msgmax=ctl} but got: "rootfs (/var) does not exist"
>>      validator_test.go:229: Expected error to not occur with
>> {fs.mqueue.ctl=ctl} but got: "rootfs (/var) does not exist"
>>
>> --- FAIL: TestNsenterValidPaths (0.01s)
>>      nsenter_test.go:65: nsenter exits with a non-zero exit status
>>
>>
>> Look like it need /var, network namespace and other things?  But thoes
>> are unittest (runc also has integrationtest target)...  Need more
>> investment.
>
> Right.  For now I think we could skip all the tests above, with a
> comment explaining the reason (/var, cgroups, and apparmor unavailable
> in the build environment.)
>

Done, thank you!


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]