emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#30786: closed (Save text properties in desktop)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#30786: closed (Save text properties in desktop)
Date: Thu, 19 Apr 2018 20:34:02 +0000

Your message dated Thu, 19 Apr 2018 23:32:14 +0300
with message-id <address@hidden>
and subject line Re: bug#30786: Save text properties in desktop
has caused the debbugs.gnu.org bug report #30786,
regarding Save text properties in desktop
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30786: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30786
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Save text properties in desktop Date: Mon, 12 Mar 2018 23:57:59 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
Why does desktop.el not save text properties?
Maybe for some historical reasons?
This is required for bug#22479.
I can't find a problem while trying this patch:

diff --git a/lisp/desktop.el b/lisp/desktop.el
index 8bd4465..a7e549f 100644
--- a/lisp/desktop.el
+++ b/lisp/desktop.el
@@ -852,10 +852,7 @@ desktop--v2s
     ((or (numberp value) (null value) (eq t value) (keywordp value))
      (cons 'may value))
     ((stringp value)
-     (let ((copy (copy-sequence value)))
-       (set-text-properties 0 (length copy) nil copy)
-       ;; Get rid of text properties because we cannot read them.
-       (cons 'may copy)))
+     (cons 'may value))
     ((symbolp value)
      (cons 'must value))
     ((vectorp value)




--- End Message ---
--- Begin Message --- Subject: Re: bug#30786: Save text properties in desktop Date: Thu, 19 Apr 2018 23:32:14 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
Version: 27.0.50

> Currently I see no better way than in the aforementioned patch.
> At least it provides 100% guarantee of readability of the desktop file
> in the same version that wrote it.

Additionally I found out that savehist uses the same solution,
so it's consistent to do the same, pushed to master as 99de04e.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]