[debbugs-tracker] bug#27897: closed (25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands)

[GNU bug Tracking System]

Your message dated Thu, 19 Apr 2018 22:36:53 +0300
with message-id <address@hidden>
and subject line Re: bug#27897: [PATCH] 25.1; Add REGION-NONCONTIGUOUS-P arg to 
other replace.el commands
has caused the debbugs.gnu.org bug report #27897,
regarding 25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27897: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27897
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands
>
>
>
>
> Date: 
>
> Mon, 31 Jul 2017 21:37:23 -0700 (PDT)
>
>
>
>
> Subject line says it all.
>
> The patch is trivial - just do the same thing to commands such as
> `replace-string', `replace-regexp', `query-replace-regexp-eval', and
> `map-query-replace-regexp' as you did to `query-replace' and
> `query-replace-regexp': add REGION-NONCONTIGUOUS-P arg to the
> interactive spec the same way, and pass it to `perform-replace' the same
> way.
>
> (Shouldn't this have been done in the first place?)
>
>
> In GNU Emacs 25.1.1 (x86_64-w64-mingw32)
>  of 2016-09-17 built on LAPHROAIG
> Windowing system distributor 'Microsoft Corp.', version 6.1.7601
> Configured using:
>  'configure --without-dbus --without-compress-install CFLAGS=-static'
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#27897: [PATCH] 25.1; Add REGION-NONCONTIGUOUS-P arg to other replace.el commands
>
>
>
>
> Date: 
>
> Thu, 19 Apr 2018 22:36:53 +0300
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
>
>
>
>
> > And some of the commands I added REGION-NONCONTIGUOUS-P to
> > already had BACKWARD, while others did not.  Should we
> > assume that whoever did that did it on purpose and wisely?
>
> query-replace-regexp-eval has no BACKWARD arg because
> query-replace-regexp-eval is obsolete and should be removed.
> map-query-replace-regexp has no BACKWARD arg because
> map-query-replace-regexp has special logic for its prefix arg.
>
> > Dunno.  My purpose here was not to fix missing BACKWARD,
> > but if you want to think about that and take care of it,
> > please do - that would be great, along with applying my
> > patch for REGION-NONCONTIGUOUS-P.
>
> Thanks, your patch pushed to master as 75a32f4.
>
>
> --- End Message ---