[debbugs-tracker] bug#31089: closed (cgit service: add support for file-like objects)

[GNU bug Tracking System]

Your message dated Wed, 11 Apr 2018 21:27:14 +0200
with message-id <address@hidden>
and subject line Re: [bug#31089] [PATCH 3/5] services: cgit: Add support for 
file-like objects.
has caused the debbugs.gnu.org bug report #31089,
regarding cgit service: add support for file-like objects
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31089: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31089
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> cgit service: add support for file-like objects
>
>
>
>
> Date: 
>
> Sat, 07 Apr 2018 19:04:17 +0200
>
>
>
>
> User-agent: 
>
> mu4e 1.0; emacs 25.3.1
>
>
>
>
> Hi,
>
> These patches aim to add support for file-like objects and a few other
> things related to the cgit service.
>
> Comments are welcome,
> Clément
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#31089] [PATCH 3/5] services: cgit: Add support for file-like objects.
>
>
>
>
> Date: 
>
> Wed, 11 Apr 2018 21:27:14 +0200
>
>
>
>
> User-agent: 
>
> mu4e 1.0; emacs 25.3.1
>
>
>
>
> Clément Lassieur <address@hidden> writes:
>
> > Ludovic Courtès <address@hidden> writes:
> >
> >>>           (config-str
> >>>            (if opaque-config?
> >>>                (opaque-cgit-configuration-cgitrc config)
> >>> -              (with-output-to-string
> >>> -                (lambda ()
> >>> -                  (serialize-configuration config
> >>> -                                           cgit-configuration-fields))))))
> >>> +              (serialize-configuration config cgit-configuration-fields))))
> >>>      #~(begin
> >>>          (use-modules (guix build utils))
> >>>          (mkdir-p #$(if opaque-config?
> >>>                         (opaque-cgit-configuration-cache-root config)
> >>>                         (cgit-configuration-cache-root config)))
> >>> -        (copy-file #$(plain-file "cgitrc" config-str) "/etc/cgitrc"))))
> >>> +        (copy-file #$(mixed-text-file "cgitrc" config-str)
> >>> +                   "/etc/cgitrc"))))
> >>
> >> For clarity, since ‘config-str’ is no longer a string (right?), I’d
> >> rename it to just ‘config’ or something.
> >>
> >> Also, could it be that you’re missing ‘apply’ above, as in:
> >>
> >>   (apply mixed-text-file "cgitrc" config-str)
> >>
> >> ?
> >
> > Yes, config-str is still a string (or a string-valued gexp).  I use
> > mixed-text-file because it can take gexps as arguments, whereas
> > plain-file can't.
> >
> >> Otherwise LGTM, thanks!
> >
> > Thank you for the review!
> >
> > Clément
>
> Pushed.
>
>
> --- End Message ---