[debbugs-tracker] bug#31046: closed ([PATCH] gnu: chromaprint: Build fpcalc)

[GNU bug Tracking System]

Your message dated Wed, 04 Apr 2018 13:56:02 +0200
with message-id <address@hidden>
and subject line Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
has caused the debbugs.gnu.org bug report #31046,
regarding [PATCH] gnu: chromaprint: Build fpcalc
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31046: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31046
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: chromaprint: Build fpcalc
>
>
>
>
> Date: 
>
> Tue,  3 Apr 2018 19:53:56 +0530
>
>
>
>
> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
>  gnu/packages/mp3.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
>      (arguments
>       `(#:tests? #f ; tests require googletest *sources*
>         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
>         #:test-target "check"))
>      (inputs
>       ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
> -- 
> 2.16.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
>
>
>
>
> Date: 
>
> Wed, 04 Apr 2018 13:56:02 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
>
>
>
>
> Hello,
>
> Pierre Neidhardt <address@hidden> skribis:
>
> > * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> > ---
> >  gnu/packages/mp3.scm | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> > index 6dc58e2cc..f57ebf575 100644
> > --- a/gnu/packages/mp3.scm
> > +++ b/gnu/packages/mp3.scm
> > @@ -508,6 +508,7 @@ command-line tool.")
> >      (arguments
> >       `(#:tests? #f ; tests require googletest *sources*
> >         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> > +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
>
> [...]
>
> > It's less than 40kb and does not require additional dependencies.
> > The size of the closure (as returned by ~guix size chromaprint~) is
> > 510.3 MB, just like before the patch.
> >
> > Considering how light it is, I don't think it's worth making a separate
> > output.
>
> Agreed.
>
> I slightly adjusted the commit log to match the conventions and
> committed.  Thank you!
>
> Ludo’.
>
>
> --- End Message ---