--- Begin Message ---
|
Subject: |
Submitting Patch for gnu: r-abc-data |
|
Date: |
Thu, 29 Mar 2018 16:46:51 +0530 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Hi
I am submitting the Patch for Package Description r-abc-data. This is a
dependency Data File for r-abc.
When i tried to build r-abc i found that the Data file is the
dependency. So i am submitting the patch for r-abc-data which is called
abc.data in the upstream. Once it is merged i will submit the r-abc patch.
https://debbugs.gnu.org/db/30/30894.html
I Tried to build r-abc-data and it resulted a success.
Please Review.
--
Regards
Sahithi
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#30983] Acknowledgement (Submitting Patch for gnu: r-abc-data) |
|
Date: |
Mon, 02 Apr 2018 23:17:06 +0200 |
|
User-agent: |
mu4e 1.0; emacs 25.3.1 |
Hi Sahithi,
thank you for the patch.
> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 6f85f0d80..8602a7d87 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -2540,14 +2540,14 @@ supports arbitrary vertex/edge/graph attributes.")
> (name "r-statnet-common")
> (version "4.0.0")
> (source
> - (origin
> - (method url-fetch)
> - (uri (cran-uri "statnet.common" version))
> - (sha256
> - (base32
> - "0yw6l5b4qv0jqlg4zyczas7m12a5pyqghs6ydxy2f6v6vxkijvi0"))))
> + (origin
> + (method url-fetch)
> + (uri (cran-uri "statnet.common" version))
> + (sha256
> + (base32
> + "0yw6l5b4qv0jqlg4zyczas7m12a5pyqghs6ydxy2f6v6vxkijvi0"))))
> (properties
> - `((upstream-name . "statnet.common")))
> + `((upstream-name . "statnet.common")))
> (build-system r-build-system)
> (home-page "http://www.statnet.org";)
> (synopsis "R scripts and utilities used by the Statnet software")
These changes don’t belong to the addition of r-abc-data, so they should
not be included. I have removed these changes before applying the
patch.
> @@ -3571,3 +3571,25 @@ and Eclat.")
> time formats, @code{parse_date} parses dates in unspecified formats,
> and @code{format_iso_8601} formats a date in ISO 8601 format.")
> (license license:gpl2)))
> +
> +(define-public r-abc-data
> + (package
> + (name "r-abc-data")
> + (version "1.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (cran-uri "abc.data" version))
> + (sha256
> + (base32
> + "1bv1n68ah714ws58cf285n2s2v5vn7382lfjca4jxph57lyg8hmj"))))
> + (properties `((upstream-name . "abc.data")))
> + (build-system r-build-system)
> + (home-page "https://cran.r-project.org/web/packages/abc.data";)
> + (synopsis "Data Only: Tools for Approximate Bayesian Computation (ABC)")
> + (description
> + "Contains data […]
Please always use complete sentences. I’ve changed this to “This
package contains …”
> + (license license:gpl3)))
According to the home page, the license is actually GPLv3 or later, so I
changed this to license:gpl3+.
I have pushed this to the master branch with commit 2a27c0bbb. Thanks
again!
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
--- End Message ---