[debbugs-tracker] bug#26498: closed ([PATCH] scripts: lint: Fix Guile build warning.)

[GNU bug Tracking System]

Your message dated Sun, 16 Apr 2017 12:09:20 +0200
with message-id <address@hidden>
and subject line Re: bug#26498: [PATCH] scripts: lint: Fix Guile build warning.
has caused the debbugs.gnu.org bug report #26498,
regarding [PATCH] scripts: lint: Fix Guile build warning.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26498: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26498
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] scripts: lint: Fix Guile build warning.
>
>
>
>
> Date: 
>
> Fri, 14 Apr 2017 15:11:13 +0200
>
>
>
>
> * guix/scripts/lint.scm (warn-if-package-has-input): Put (_ message)
>   in let, to avoid the following warning :
>
> guix/scripts/lint.scm:251:37: warning: non-literal format string
> ---
>  guix/scripts/lint.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> index 811f16706..1105dc418 100644
> --- a/guix/scripts/lint.scm
> +++ b/guix/scripts/lint.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright © 2016 Danny Milosavljevic <address@hidden>
>  ;;; Copyright © 2016 Hartmut Goebel <address@hidden>
>  ;;; Copyright © 2017 Alex Kost <address@hidden>
> +;;; Copyright © 2017 Mathieu Othacehe <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -245,10 +246,13 @@ by two spaces; possible infraction~p at ~{~a~^, ~}")
>                                   (package-name package)
>                                   (if (> (length output) 0)
>                                       (string-append ":" (car output))
> -                                     ""))))
> +                                     "")))
> +                         ;; Putting tr-msg in let prevents from this
> +                         ;; Guile warning: "non-literal format string".
> +                         (tr-msg (_ message)))
>                       (when (member input input-names)
>                         (emit-warning linted
> -                                     (format #f (_ message) input)
> +                                     (format #f tr-msg input)
>                                       'inputs-to-check)))))
>                 packages outputs))))
>  
> -- 
> 2.12.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#26498: [PATCH] scripts: lint: Fix Guile build warning.
>
>
>
>
> Date: 
>
> Sun, 16 Apr 2017 12:09:20 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
>
>
>
>
> Hi Mathieu,
>
> Mathieu Othacehe <address@hidden> skribis:
>
> > * guix/scripts/lint.scm (warn-if-package-has-input): Put (_ message)
> >   in let, to avoid the following warning :
> >
> > guix/scripts/lint.scm:251:37: warning: non-literal format string
> > ---
> >  guix/scripts/lint.scm | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> > index 811f16706..1105dc418 100644
> > --- a/guix/scripts/lint.scm
> > +++ b/guix/scripts/lint.scm
> > @@ -6,6 +6,7 @@
> >  ;;; Copyright © 2016 Danny Milosavljevic <address@hidden>
> >  ;;; Copyright © 2016 Hartmut Goebel <address@hidden>
> >  ;;; Copyright © 2017 Alex Kost <address@hidden>
> > +;;; Copyright © 2017 Mathieu Othacehe <address@hidden>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -245,10 +246,13 @@ by two spaces; possible infraction~p at ~{~a~^, ~}")
> >                                   (package-name package)
> >                                   (if (> (length output) 0)
> >                                       (string-append ":" (car output))
> > -                                     ""))))
> > +                                     "")))
> > +                         ;; Putting tr-msg in let prevents from this
> > +                         ;; Guile warning: "non-literal format string".
> > +                         (tr-msg (_ message)))
> >                       (when (member input input-names)
> >                         (emit-warning linted
> > -                                     (format #f (_ message) input)
> > +                                     (format #f tr-msg input)
>
> Not OK.  :-)
>
> The warning is expected here, it warns about a real issue, which is that
> we’re passing a non-literal format string.
>
> I fixed it by decoupling the computational from the UI part in commit
> 1730c5b509c236a948b5a91ae6b7063384c1eee6.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---