|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#22996: closed ([PATCH] Use directory_files_internal_unwind() in directory_files_internal ()) |
Date: | Sun, 20 Mar 2016 01:49:02 +0000 |
Your message dated Sat, 19 Mar 2016 18:47:47 -0700 with message-id <address@hidden> and subject line Re: [PATCH] Use directory_files_internal_unwind() in directory_files_internal () has caused the debbugs.gnu.org bug report #22996, regarding [PATCH] Use directory_files_internal_unwind() in directory_files_internal () to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 22996: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22996 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: [PATCH] Use directory_files_internal_unwind() in directory_files_internal () Date: Sat, 12 Mar 2016 19:49:37 +0600 src/dired.c (directory_files_internal): use directory_files_internal_unwind() to prevent code duplication. --- src/dired.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/dired.c b/src/dired.c index ebc7029..b5b6af6 100644 --- a/src/dired.c +++ b/src/dired.c @@ -307,9 +307,7 @@ directory_files_internal (Lisp_Object directory, Lisp_Object full, } } - block_input (); - closedir (d); - unblock_input (); + directory_files_internal_unwind ((void*) d); #ifdef WINDOWSNT if (attrs) Vw32_get_true_file_attributes = w32_save; -- 2.8.0.rc0.61.g9f22707
--- End Message ---
--- Begin Message ---Subject: Re: [PATCH] Use directory_files_internal_unwind() in directory_files_internal () Date: Sat, 19 Mar 2016 18:47:47 -0700 Thanks for pointing out the code infelicity. I installed the attached, which cleans it up in a more-general way. User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 0001-No-need-to-block-input-when-reading-directories.txt
Description: Text document
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |