[debbugs-tracker] bug#21122: closed (compilation error (-Wunused-macros) with gcc-5.2)

[GNU bug Tracking System]

Your message dated Sat, 1 Aug 2015 09:17:54 -0700
with message-id <address@hidden>
and subject line Re: bug#21122: compilation error (-Wunused-macros) with gcc-5.2
has caused the debbugs.gnu.org bug report #21122,
regarding compilation error (-Wunused-macros) with gcc-5.2
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
21122: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21122
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: compilation error (-Wunused-macros) with gcc-5.2 Date: Thu, 23 Jul 2015 17:42:19 -0400 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

Hello,

compiling sed from git (v4.2.2-89-ge387009) fails with gcd-5.2 due to 
-Wunused-macros (and -Werror):

===
make[3]: Entering directory `/home/gordon/sources/sed/sed'
  CC       compile.o
compile.c:36:0: error: macro "OPEN_BRACE" is not used [-Werror=unused-macros]
 #define OPEN_BRACE '{'
 ^
compile.c:183:0: error: macro "END_ERRORS" is not used [-Werror=unused-macros]
 #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command")))
 ^
cc1: all warnings being treated as errors
make[3]: *** [compile.o] Error 1
===

The attached patch comments-out the two macros. Alternatively they could be 
simply erased.

regards,
 - assaf

P.S.
I don't yet have copyright assignment for sed, but I think this change is 
trivial enough.

sed-unused-macros.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#21122: compilation error (-Wunused-macros) with gcc-5.2
>
>
>
>
> Date: 
>
> Sat, 1 Aug 2015 09:17:54 -0700
>
>
>
>
> On Thu, Jul 23, 2015 at 2:42 PM, Assaf Gordon <address@hidden> wrote:
> > Hello,
> >
> > compiling sed from git (v4.2.2-89-ge387009) fails with gcd-5.2 due to
> > -Wunused-macros (and -Werror):
> >
> > ===
> > make[3]: Entering directory `/home/gordon/sources/sed/sed'
> >   CC       compile.o
> > compile.c:36:0: error: macro "OPEN_BRACE" is not used
> > [-Werror=unused-macros]
> >  #define OPEN_BRACE '{'
> >  ^
> > compile.c:183:0: error: macro "END_ERRORS" is not used
> > [-Werror=unused-macros]
> >  #define END_ERRORS (INCOMPLETE_CMD + sizeof(N_("incomplete command")))
> >  ^
> > cc1: all warnings being treated as errors
> > make[3]: *** [compile.o] Error 1
> > ===
> >
> > The attached patch comments-out the two macros. Alternatively they could be
> > simply erased.
>
> Thank you. I've pushed that with slight tweaks to the commit log.
>
> > P.S.
> > I don't yet have copyright assignment for sed, but I think this change is
> > trivial enough.
>
> Yes, that's fine.
>
>
> --- End Message ---