[debbugs-tracker] bug#20908: closed (25.0.50; gnutls-negotiate error "Invalid format operation %u")

[GNU bug Tracking System]

Your message dated Sat, 27 Jun 2015 11:05:19 +0300
with message-id <address@hidden>
and subject line Re: bug#20908: 25.0.50; gnutls-negotiate error "Invalid format 
operation %u"
has caused the debbugs.gnu.org bug report #20908,
regarding 25.0.50; gnutls-negotiate error "Invalid format operation %u"
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20908: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20908
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 25.0.50; gnutls-negotiate error "Invalid format operation %u" Date: Sat, 27 Jun 2015 11:55:43 +0800

Hi all,
I've got a problem: when using (gnutls-negotiate :verify-error t) to initialize 
a SSL/TLS
connection , server has an expired certificate cause gnutls-boot signal
an error "Invalid format operation %u", apparently it's not related to
gnutls-error. So digging into the source
code, here is the error signal:

src/gnutls.c:1511

      if (verify_error_all
          || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
        {
          emacs_gnutls_deinit (proc);
          error ("Certificate validation failed %s, verification code %u",
                 c_hostname, peer_verification);
        }

After checking elisp manual and source code, function Fformat(error call
it to format string) does not
support '%u', here should using '%d' instead.

I made a simple patch for this:

0001-gnutls-boot-fix-error-Invalid-format-operation-u-whe.patch
Description: 0001-gnutls-boot-fix-error-Invalid-format-operation-u-whe.patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#20908: 25.0.50; gnutls-negotiate error "Invalid format operation %u"
>
>
>
>
> Date: 
>
> Sat, 27 Jun 2015 11:05:19 +0300
>
>
>
>
> > From: lo2net <address@hidden>
> > Date: Sat, 27 Jun 2015 11:55:43 +0800
> > 
> > I've got a problem: when using (gnutls-negotiate :verify-error t) to 
> > initialize a SSL/TLS
> > connection , server has an expired certificate cause gnutls-boot signal
> > an error "Invalid format operation %u", apparently it's not related to
> > gnutls-error. So digging into the source
> > code, here is the error signal:
> > 
> > src/gnutls.c:1511
> > 
> >       if (verify_error_all
> >           || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
> >         {
> >         emacs_gnutls_deinit (proc);
> >         error ("Certificate validation failed %s, verification code %u",
> >                c_hostname, peer_verification);
> >         }
> > 
> > After checking elisp manual and source code, function Fformat(error call
> > it to format string) does not
> > support '%u', here should using '%d' instead.
> > 
> > I made a simple patch for this:
>
> Thanks.  I used %x instead of %d in the change I just pushed, because
> the peer_verification value is actually a bitwise OR of the various
> bits, so displaying it in hex will make its interpretation easier.
>
> With that, I'm marking this bug done.
>
>
> --- End Message ---